netdev - Re: [PATCH net-next v2 3/5] net: phylink: allow mac_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241017070027.3vt5eydezrx5d6ke@skbuf>
Date: Thu, 17 Oct 2024 10:00:27 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next v2 3/5] net: phylink: allow mac_select_pcs() to
 remove a PCS

On Wed, Oct 16, 2024 at 10:58:34AM +0100, Russell King (Oracle) wrote:
> phylink has historically not permitted a PCS to be removed. An attempt
> to permit this with phylink_set_pcs() resulted in comments indicating
> that there was no need for this. This behaviour has been propagated
> forward to the mac_select_pcs() approach as it was believed from these
> comments that changing this would be NAK'd.
> 
> However, with mac_select_pcs(), it takes more code and thus complexity
> to maintain this behaviour, which can - and in this case has - resulted
> in a bug. If mac_select_pcs() returns NULL for a particular interface
> type, but there is already a PCS in-use, then we skip the pcs_validate()
> method, but continue using the old PCS. Also, it wouldn't be expected
> behaviour by implementers of mac_select_pcs().
> 
> Allow this by removing this old unnecessary restriction.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> ---

Reviewed-by: Vladimir Oltean <olteanv@...il.com>