netdev - Re: [PATCH net-next v2 4/5] net: phylink: remove use of pl->pcs in phylink_validate_mac_and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241017070121.soahbrrhgp7bpdjk@skbuf>
Date: Thu, 17 Oct 2024 10:01:21 +0300
From: Vladimir Oltean <olteanv@...il.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next v2 4/5] net: phylink: remove use of pl->pcs in
 phylink_validate_mac_and_pcs()

On Wed, Oct 16, 2024 at 10:58:39AM +0100, Russell King (Oracle) wrote:
> When the mac_select_pcs() method is not implemented, there is no way
> for pl->pcs to be set to a non-NULL value. This was here to support
> the old phylink_set_pcs() method which has been removed a few years
> ago. Simplify the code in phylink_validate_mac_and_pcs().
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>
> ---

Reviewed-by: Vladimir Oltean <olteanv@...il.com>