[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a498aca1ac932d66d38282fbfe614d927691ec01.camel@mediatek.com>
Date: Wed, 16 Oct 2024 16:25:14 +0000
From: SkyLake Huang (黃啟澤)
<SkyLake.Huang@...iatek.com>
To: "horms@...nel.org" <horms@...nel.org>
CC: "andrew@...n.ch" <andrew@...n.ch>, "linux-kernel@...r.kernel.org"
<linux-kernel@...r.kernel.org>, "linux-mediatek@...ts.infradead.org"
<linux-mediatek@...ts.infradead.org>, "linux@...linux.org.uk"
<linux@...linux.org.uk>, "kuba@...nel.org" <kuba@...nel.org>,
"pabeni@...hat.com" <pabeni@...hat.com>, "edumazet@...gle.com"
<edumazet@...gle.com>, "linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>, "netdev@...r.kernel.org"
<netdev@...r.kernel.org>, "dqfext@...il.com" <dqfext@...il.com>,
"matthias.bgg@...il.com" <matthias.bgg@...il.com>,
Steven Liu (劉人豪) <steven.liu@...iatek.com>,
"davem@...emloft.net" <davem@...emloft.net>, "hkallweit1@...il.com"
<hkallweit1@...il.com>, AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>, "daniel@...rotopia.org"
<daniel@...rotopia.org>
Subject: Re: [PATCH net-next 1/1] net: phy: Refactor mediatek-ge-soc.c for
clarity and correctness
> I do think that would be best.
> But if you strongly think otherwise I can try to review it as-is.
Hi Simon,
If this does cause trouble for reviewing, I can split it into a few
patches:
Patch 1: Fix spelling errors + reverse Xmas tree + remove unnecessary
parens
Patch 2: Shrink mtk-ge-soc.c line wrapping to 80 characters.
Patch 3: Propagate error code correctly in cal_cycle() + FIELD_GET()
change
Patch 4: Fix multi functions with FIELD_PREP().
Is this okay for you? Do I need to split them into more patches?
BRs,
Sky
Powered by blists - more mailing lists