netdev - Re: [PATCH net v6 05/10] ip6mr: Lock RTNL before ip6mr_new_table() call in ip6mr_rules

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2815af1a-d7dd-4679-bb16-842925880b10@nokia.com>
Date: Fri, 18 Oct 2024 12:41:44 +0200
From: Stefan Wiehler <stefan.wiehler@...ia.com>
To: Florian Westphal <fw@...len.de>
Cc: "David S . Miller" <davem@...emloft.net>, David Ahern
 <dsahern@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net v6 05/10] ip6mr: Lock RTNL before ip6mr_new_table()
 call in ip6mr_rules_init()

>> +     rtnl_lock();
>>       mrt = ip6mr_new_table(net, RT6_TABLE_DFLT);
>>       if (IS_ERR(mrt)) {
>>               err = PTR_ERR(mrt);
>>               goto err1;
>>       }
>> +     rtnl_unlock();
>>
>>       err = fib_default_rule_add(ops, 0x7fff, RT6_TABLE_DFLT, 0);
>>       if (err < 0)
>> @@ -254,6 +256,7 @@ static int __net_init ip6mr_rules_init(struct net *net)
>>       ip6mr_free_table(mrt);
>>       rtnl_unlock();
>>  err1:
>> +     rtnl_unlock();
> 
> Looks like a double-unlock?

Thanks, will fix in v7.