netdev - Re: [PATCH iwl-next v9 6/6] igb: Add AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87frot8zap.fsf@kurt.kurt.home>
Date: Fri, 18 Oct 2024 12:45:34 +0200
From: Kurt Kanzenbach <kurt@...utronix.de>
To: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>, Przemek Kitszel
 <przemyslaw.kitszel@...el.com>, "David S. Miller" <davem@...emloft.net>,
 Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, Alexei Starovoitov <ast@...nel.org>, Daniel
 Borkmann <daniel@...earbox.net>, Jesper Dangaard Brouer <hawk@...nel.org>,
 John Fastabend <john.fastabend@...il.com>, Richard Cochran
 <richardcochran@...il.com>, Sriram Yagnaraman
 <sriram.yagnaraman@...csson.com>, Benjamin Steinke
 <benjamin.steinke@...s-audio.com>, Sebastian Andrzej Siewior
 <bigeasy@...utronix.de>, intel-wired-lan@...ts.osuosl.org,
 netdev@...r.kernel.org, bpf@...r.kernel.org, Sriram Yagnaraman
 <sriram.yagnaraman@....tech>
Subject: Re: [PATCH iwl-next v9 6/6] igb: Add AF_XDP zero-copy Tx support

On Fri Oct 18 2024, Maciej Fijalkowski wrote:
> On Fri, Oct 18, 2024 at 10:40:02AM +0200, Kurt Kanzenbach wrote:
>> From: Sriram Yagnaraman <sriram.yagnaraman@....tech>
>> 
>> Add support for AF_XDP zero-copy transmit path.
>> 
>> A new TX buffer type IGB_TYPE_XSK is introduced to indicate that the Tx
>> frame was allocated from the xsk buff pool, so igb_clean_tx_ring() and
>> igb_clean_tx_irq() can clean the buffers correctly based on type.
>> 
>> igb_xmit_zc() performs the actual packet transmit when AF_XDP zero-copy is
>> enabled. We share the TX ring between slow path, XDP and AF_XDP
>> zero-copy, so we use the netdev queue lock to ensure mutual exclusion.
>> 
>> Signed-off-by: Sriram Yagnaraman <sriram.yagnaraman@....tech>
>> [Kurt: Set olinfo_status in igb_xmit_zc() so that frames are transmitted,
>>        Use READ_ONCE() for xsk_pool and check Tx disabled and carrier in
>>        igb_xmit_zc(), Add FIXME for RS bit]
>> Signed-off-by: Kurt Kanzenbach <kurt@...utronix.de>
>> Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
>
> I didn't give you my tag on this patch in previous revision, but from what
> I can see now it can stay here:)

At some point you did [1]. And I didn't remove it, because it felt like
only small changes like adding the FIXME and re-using the xsk pool
pointer were made.

>
> Finally, thanks!
>

Yay :). Thanks for your review and time spent.

[1] - https://lore.kernel.org/intel-wired-lan/ZsNzLvH38p%2FcWwI0@boxer/

Download attachment "signature.asc" of type "application/pgp-signature" (862 bytes)