netdev - RE: [Intel-wired-lan] [PATCH iwl-next v9 6/6] igb: Add AF

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH0PR11MB51448FE0C7FDD3C1B00D8DC6E2482@PH0PR11MB5144.namprd11.prod.outlook.com>
Date: Sat, 26 Oct 2024 16:45:31 +0000
From: "Kuruvinakunnel, George" <george.kuruvinakunnel@...el.com>
To: Kurt Kanzenbach <kurt@...utronix.de>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
CC: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
	<edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>, Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann
	<daniel@...earbox.net>, Jesper Dangaard Brouer <hawk@...nel.org>, "John
 Fastabend" <john.fastabend@...il.com>, Richard Cochran
	<richardcochran@...il.com>, Sriram Yagnaraman
	<sriram.yagnaraman@...csson.com>, Benjamin Steinke
	<benjamin.steinke@...s-audio.com>, Sebastian Andrzej Siewior
	<bigeasy@...utronix.de>, "Fijalkowski, Maciej"
	<maciej.fijalkowski@...el.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "bpf@...r.kernel.org" <bpf@...r.kernel.org>, Sriram
 Yagnaraman <sriram.yagnaraman@....tech>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v9 6/6] igb: Add AF_XDP
 zero-copy Tx support

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of
> Kurt Kanzenbach
> Sent: Friday, October 18, 2024 1:40 AM
> To: Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>
> Cc: David S. Miller <davem@...emloft.net>; Eric Dumazet
> <edumazet@...gle.com>; Jakub Kicinski <kuba@...nel.org>; Paolo Abeni
> <pabeni@...hat.com>; Alexei Starovoitov <ast@...nel.org>; Daniel
> Borkmann <daniel@...earbox.net>; Jesper Dangaard Brouer
> <hawk@...nel.org>; John Fastabend <john.fastabend@...il.com>; Richard
> Cochran <richardcochran@...il.com>; Sriram Yagnaraman
> <sriram.yagnaraman@...csson.com>; Benjamin Steinke
> <benjamin.steinke@...s-audio.com>; Sebastian Andrzej Siewior
> <bigeasy@...utronix.de>; Fijalkowski, Maciej <maciej.fijalkowski@...el.com>;
> intel-wired-lan@...ts.osuosl.org; netdev@...r.kernel.org;
> bpf@...r.kernel.org; Sriram Yagnaraman <sriram.yagnaraman@....tech>;
> Kurt Kanzenbach <kurt@...utronix.de>
> Subject: [Intel-wired-lan] [PATCH iwl-next v9 6/6] igb: Add AF_XDP zero-copy
> Tx support
> 
> From: Sriram Yagnaraman <sriram.yagnaraman@....tech>
> 
> Add support for AF_XDP zero-copy transmit path.
> 
> A new TX buffer type IGB_TYPE_XSK is introduced to indicate that the Tx frame
> was allocated from the xsk buff pool, so igb_clean_tx_ring() and
> igb_clean_tx_irq() can clean the buffers correctly based on type.
> 
> igb_xmit_zc() performs the actual packet transmit when AF_XDP zero-copy is
> enabled. We share the TX ring between slow path, XDP and AF_XDP zero-
> copy, so we use the netdev queue lock to ensure mutual exclusion.
> 
> Signed-off-by: Sriram Yagnaraman <sriram.yagnaraman@....tech>
> [Kurt: Set olinfo_status in igb_xmit_zc() so that frames are transmitted,
>        Use READ_ONCE() for xsk_pool and check Tx disabled and carrier in
>        igb_xmit_zc(), Add FIXME for RS bit]
> Signed-off-by: Kurt Kanzenbach <kurt@...utronix.de>
> Reviewed-by: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
> ---
>  drivers/net/ethernet/intel/igb/igb.h      |  2 +
>  drivers/net/ethernet/intel/igb/igb_main.c | 61
> +++++++++++++++++++++++++-----
> drivers/net/ethernet/intel/igb/igb_xsk.c  | 63
> +++++++++++++++++++++++++++++++
>  3 files changed, 116 insertions(+), 10 deletions(-)
> 

Tested-by: George Kuruvinakunnel <george.kuruvinakunnel@...el.com>