netdev - Re: [PATCH iwl-next v3 1/2] ice: refactor "last" segment of DDP pkg

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241019083502.GJ1697@kernel.org>
Date: Sat, 19 Oct 2024 09:35:02 +0100
From: Simon Horman <horms@...nel.org>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org,
	Tony Nguyen <anthony.l.nguyen@...el.com>, netdev@...r.kernel.org,
	Jacob Keller <jacob.e.keller@...el.com>,
	Paul Greenwalt <paul.greenwalt@...el.com>,
	Dan Nowlin <dan.nowlin@...el.com>,
	Ahmed Zaki <ahmed.zaki@...el.com>,
	Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
	Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com>
Subject: Re: [PATCH iwl-next v3 1/2] ice: refactor "last" segment of DDP pkg

On Fri, Oct 18, 2024 at 04:17:36PM +0200, Przemek Kitszel wrote:
> Add ice_ddp_send_hunk() that buffers "sent FW hunk" calls to AQ in order
> to mark the "last" one in more elegant way. Next commit will add even
> more complicated "sent FW" flow, so it's better to untangle a bit before.
> 
> Note that metadata buffers were not skipped for NOT-@...icate_last
> segments, this is fixed now.
> 
> Minor:
>  + use ice_is_buffer_metadata() instead of open coding it in
>    ice_dwnld_cfg_bufs();
>  + ice_dwnld_cfg_bufs_no_lock() + dependencies were moved up a bit to have
>    better git-diff, as this function was rewritten (in terms of git-blame)
> 
> CC: Paul Greenwalt <paul.greenwalt@...el.com>
> CC: Dan Nowlin <dan.nowlin@...el.com>
> CC: Ahmed Zaki <ahmed.zaki@...el.com>
> CC: Simon Horman <horms@...nel.org>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)
> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> ---
> git: --inter-hunk-context=6
> 
> v3: added ice_ddp_send_ctx_set_err() to avoid "user" code setting
>     the ctx->err directly, fix kdoc warnings, removed redundant
>     assignement, typo fix, all thanks to Simon
> v2: fixed one kdoc warning

Thanks for the updates.

Reviewed-by: Simon Horman <horms@...nel.org>