netdev - Re: [PATCH iwl-next v3 2/2] ice: support optional flags in signature segment header

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241019083517.GK1697@kernel.org>
Date: Sat, 19 Oct 2024 09:35:17 +0100
From: Simon Horman <horms@...nel.org>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Cc: intel-wired-lan@...ts.osuosl.org,
	Tony Nguyen <anthony.l.nguyen@...el.com>, netdev@...r.kernel.org,
	Jacob Keller <jacob.e.keller@...el.com>,
	Paul Greenwalt <paul.greenwalt@...el.com>,
	Ahmed Zaki <ahmed.zaki@...el.com>,
	Dan Nowlin <dan.nowlin@...el.com>,
	Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
	Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com>
Subject: Re: [PATCH iwl-next v3 2/2] ice: support optional flags in signature
 segment header

On Fri, Oct 18, 2024 at 04:17:37PM +0200, Przemek Kitszel wrote:
> An optional flag field has been added to the signature segment header.
> The field contains two flags, a "valid" bit, and a "last segment" bit
> that indicates whether the segment is the last segment that will be
> sent to firmware.
> 
> If the flag field's valid bit is NOT set, then as was done before,
> assume that this is the last segment being downloaded.
> 
> However, if the flag field's valid bit IS set, then use the last segment
> flag to determine if this segment is the last segment to download.
> 
> Signed-off-by: Paul Greenwalt <paul.greenwalt@...el.com>
> Signed-off-by: Ahmed Zaki <ahmed.zaki@...el.com>
> Co-developed-by: Dan Nowlin <dan.nowlin@...el.com>
> Signed-off-by: Dan Nowlin <dan.nowlin@...el.com>
> Reviewed-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)
> Signed-off-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
> ---
> v2: co/- authorship change

Reviewed-by: Simon Horman <horms@...nel.org>