netdev - RE: [PATCH v3 net-next 02/13] dt-bindings: net: add i.MX95 ENETC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB85102D0CDA35B2D8E09F8F8E88412@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Sat, 19 Oct 2024 09:58:50 +0000
From: Wei Fang <wei.fang@....com>
To: Rob Herring <robh@...nel.org>, Frank Li <frank.li@....com>
CC: "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>, Vladimir
 Oltean <vladimir.oltean@....com>, Claudiu Manoil <claudiu.manoil@....com>,
	Clark Wang <xiaoning.wang@....com>, "christophe.leroy@...roup.eu"
	<christophe.leroy@...roup.eu>, "linux@...linux.org.uk"
	<linux@...linux.org.uk>, "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
	"horms@...nel.org" <horms@...nel.org>, "imx@...ts.linux.dev"
	<imx@...ts.linux.dev>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>
Subject: RE: [PATCH v3 net-next 02/13] dt-bindings: net: add i.MX95 ENETC
 support

> -----Original Message-----
> From: Rob Herring <robh@...nel.org>
> Sent: 2024年10月18日 21:09
> To: Frank Li <frank.li@....com>
> Cc: Wei Fang <wei.fang@....com>; davem@...emloft.net;
> edumazet@...gle.com; kuba@...nel.org; pabeni@...hat.com;
> krzk+dt@...nel.org; conor+dt@...nel.org; Vladimir Oltean
> <vladimir.oltean@....com>; Claudiu Manoil <claudiu.manoil@....com>;
> Clark Wang <xiaoning.wang@....com>; christophe.leroy@...roup.eu;
> linux@...linux.org.uk; bhelgaas@...gle.com; horms@...nel.org;
> imx@...ts.linux.dev; netdev@...r.kernel.org; devicetree@...r.kernel.org;
> linux-kernel@...r.kernel.org; linux-pci@...r.kernel.org
> Subject: Re: [PATCH v3 net-next 02/13] dt-bindings: net: add i.MX95 ENETC
> support
> 
> On Thu, Oct 17, 2024 at 12:23:05PM -0400, Frank Li wrote:
> > On Thu, Oct 17, 2024 at 03:46:26PM +0800, Wei Fang wrote:
> > > The ENETC of i.MX95 has been upgraded to revision 4.1, and the
> > > vendor ID and device ID have also changed, so add the new compatible
> > > strings for i.MX95 ENETC. In addition, i.MX95 supports configuration
> > > of RGMII or RMII reference clock.
> > >
> > > Signed-off-by: Wei Fang <wei.fang@....com>
> > > ---
> > > v2: Remove "nxp,imx95-enetc" compatible string.
> > > v3:
> > > 1. Add restriction to "clcoks" and "clock-names" properties and
> > > rename the clock, also remove the items from these two properties.
> > > 2. Remove unnecessary items for "pci1131,e101" compatible string.
> > > ---
> > >  .../devicetree/bindings/net/fsl,enetc.yaml    | 22 ++++++++++++++++---
> > >  1 file changed, 19 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > > b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > > index e152c93998fe..e418c3e6e6b1 100644
> > > --- a/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > > +++ b/Documentation/devicetree/bindings/net/fsl,enetc.yaml
> > > @@ -20,10 +20,13 @@ maintainers:
> > >
> > >  properties:
> > >    compatible:
> > > -    items:
> > > +    oneOf:
> > > +      - items:
> > > +          - enum:
> > > +              - pci1957,e100
> > > +          - const: fsl,enetc
> > >        - enum:
> > > -          - pci1957,e100
> > > -      - const: fsl,enetc
> > > +          - pci1131,e101
> > >
> > >    reg:
> > >      maxItems: 1
> > > @@ -40,6 +43,19 @@ required:
> > >  allOf:
> > >    - $ref: /schemas/pci/pci-device.yaml
> > >    - $ref: ethernet-controller.yaml
> > > +  - if:
> > > +      properties:
> > > +        compatible:
> > > +          contains:
> > > +            enum:
> > > +              - pci1131,e101
> > > +    then:
> > > +      properties:
> > > +        clocks:
> > > +          maxItems: 1
> > > +          description: MAC transmit/receiver reference clock
> > > +        clock-names:
> > > +          const: ref
> >
> > Did you run CHECK_DTBS for your dts file? clocks\clock-names should be
> > under top 'properties" firstly. Then use 'if' restrict it. But I am
> > not sure for that. only dt_binding_check is not enough because your
> > example have not use clocks and clok-names.
> 
> That's a manual check, but yes. Define all properties at top level.
> 

Okay, I will move them to top level, thanks.