netdev - Re: [PATCH net-next 0/3] net: phylink: simplify SFP PHY attachment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZxeTsApaFCIjl5RH@shell.armlinux.org.uk>
Date: Tue, 22 Oct 2024 12:59:44 +0100
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Maxime Chevallier <maxime.chevallier@...tlin.com>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org,
	Paolo Abeni <pabeni@...hat.com>
Subject: Re: [PATCH net-next 0/3] net: phylink: simplify SFP PHY attachment

On Tue, Oct 22, 2024 at 01:54:47PM +0200, Maxime Chevallier wrote:
> Hello Russell,
> 
> On Tue, 22 Oct 2024 12:39:06 +0100
> "Russell King (Oracle)" <linux@...linux.org.uk> wrote:
> 
> > Hi,
> > 
> > These two patches simplify how we attach SFP PHYs.
> > 
> > The first patch notices that at the two sites where we call
> > sfp_select_interface(), if that fails, we always print the same error.
> > Move this into its own function.
> > 
> > The second patch adds an additional level of validation, checking that
> > the returned interface is one that is supported by the MAC/PCS.
> > 
> > The last patch simplifies how SFP PHYs are attached, reducing the
> > number of times that we do validation in this path.
> > 
> >  drivers/net/phy/phylink.c | 82 ++++++++++++++++++++++++-----------------------
> >  1 file changed, 42 insertions(+), 40 deletions(-)
> 
> It looks like the patches didn't make it through, there're also not on
> lore nor patchwork :(

You're too quick. I was delaying the patches for two reasons:

1) to ensure Jakub's nipa bot bug doesn't get me again.
2) build-testing the series, as I'd made a change... and unsurprisingly
   not waiting for that to finish, and sending the patches, immediately
   after sending it found a problem. :(

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!