netdev - Re: [PATCH net-next 1/3] net: phylink: add common validation for sfp_select

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241022154717.08c56cc9@device-21.home>
Date: Tue, 22 Oct 2024 15:47:17 +0200
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: "Russell King (Oracle)" <rmk+kernel@...linux.org.uk>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 1/3] net: phylink: add common validation for
 sfp_select_interface()

On Tue, 22 Oct 2024 12:54:07 +0100
"Russell King (Oracle)" <rmk+kernel@...linux.org.uk> wrote:

> Whenever we call sfp_select_interface(), we check the returned value
> and print an error. There are two cases where this happens with the
> same message. Provide a common function to do this.
> 
> Signed-off-by: Russell King (Oracle) <rmk+kernel@...linux.org.uk>

I gave the series a test on 2 platforms I have that use phylink with
SFPs:

 - The Macchiatobin, interface eth3 with different copper modules
 - A board that has an Armada 3720 wired to an SFP cage

Reviewed-by: Maxime Chevallier <maxime.chevallier@...tlin.com>
Tested-by: Maxime Chevallier <maxime.chevallier@...tlin.com>

Thanks,

Maxime