netdev - Re: [Intel-wired-lan] [PATCH v2 1/1] [net-next] igb: Fix spelling in igb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba58bbcd-079e-42b9-8e66-52b2626936e2@molgen.mpg.de>
Date: Wed, 23 Oct 2024 10:04:45 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Johnny Park <pjohnny0508@...il.com>
Cc: horms@...nel.org, anthony.l.nguyen@...el.com,
 przemyslaw.kitszel@...el.com, davem@...emloft.net, edumazet@...gle.com,
 kuba@...nel.org, pabeni@...hat.com, andrew@...n.ch,
 intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
 kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [Intel-wired-lan] [PATCH v2 1/1] [net-next] igb: Fix spelling in
 igb_main.c

Dear Johnny,


Thank you for your patch. I recommend to put the information, that the 
typos are only in comments, to the summary/title:

igb: Fix 2 typos in comments in igb_main.c

That way, skimming `git log --oneline` is more informative.

Am 23.10.24 um 05:21 schrieb Johnny Park:
> Simple patch that fix spelling mistakes in igb_main.c

fix*es*, but better use imperative mood:

Fix 2 spelling mistakes in comments `igb_main.c`.

> Signed-off-by: Johnny Park <pjohnny0508@...il.com>
> ---
> Changes in v2:
>    - Fix spelling mor -> more
> ---
>   drivers/net/ethernet/intel/igb/igb_main.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/intel/igb/igb_main.c
> index 1ef4cb871452..fc587304b3c0 100644
> --- a/drivers/net/ethernet/intel/igb/igb_main.c
> +++ b/drivers/net/ethernet/intel/igb/igb_main.c
> @@ -1204,7 +1204,7 @@ static int igb_alloc_q_vector(struct igb_adapter *adapter,
>   	/* initialize pointer to rings */
>   	ring = q_vector->ring;
>   
> -	/* intialize ITR */
> +	/* initialize ITR */
>   	if (rxr_count) {
>   		/* rx or rx/tx vector */
>   		if (!adapter->rx_itr_setting || adapter->rx_itr_setting > 3)
> @@ -3906,7 +3906,7 @@ static void igb_remove(struct pci_dev *pdev)
>    *
>    *  This function initializes the vf specific data storage and then attempts to
>    *  allocate the VFs.  The reason for ordering it this way is because it is much
> - *  mor expensive time wise to disable SR-IOV than it is to allocate and free
> + *  more expensive time wise to disable SR-IOV than it is to allocate and free
>    *  the memory for the VFs.
>    **/
>   static void igb_probe_vfs(struct igb_adapter *adapter)

Rest looks good.


Kind regards,

Paul