netdev - Re: [PATCH net-next 1/2] net: netconsole: selftests: Change the IP subnet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87ed44kt92.fsf@nvidia.com>
Date: Fri, 25 Oct 2024 19:01:59 +0200
From: Petr Machata <petrm@...dia.com>
To: Breno Leitao <leitao@...ian.org>
CC: <kuba@...nel.org>, <horms@...nel.org>, <davem@...emloft.net>,
	<edumazet@...gle.com>, <pabeni@...hat.com>, <matttbe@...nel.org>, Andrew Lunn
	<andrew+netdev@...n.ch>, Shuah Khan <shuah@...nel.org>,
	<thepacketgeek@...il.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <davej@...emonkey.org.uk>,
	<vlad.wing@...il.com>, <max@...sevol.com>, <kernel-team@...a.com>,
	<aehkn@...hub.one>, Petr Machata <petrm@...dia.com>, "open list:KERNEL
 SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH net-next 1/2] net: netconsole: selftests: Change the IP
 subnet


Breno Leitao <leitao@...ian.org> writes:

> Use a less populated IP range to run the tests, as suggested by Petr in
> Link: https://lore.kernel.org/netdev/87ikvukv3s.fsf@nvidia.com/.
>
> Suggested-by: Petr Machata <petrm@...dia.com>
> Signed-off-by: Breno Leitao <leitao@...ian.org>
> ---
>  tools/testing/selftests/drivers/net/netcons_basic.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tools/testing/selftests/drivers/net/netcons_basic.sh b/tools/testing/selftests/drivers/net/netcons_basic.sh
> index 06021b2059b7..4ad1e216c6b0 100755
> --- a/tools/testing/selftests/drivers/net/netcons_basic.sh
> +++ b/tools/testing/selftests/drivers/net/netcons_basic.sh
> @@ -20,9 +20,9 @@ SCRIPTDIR=$(dirname "$(readlink -e "${BASH_SOURCE[0]}")")
>  
>  # Simple script to test dynamic targets in netconsole
>  SRCIF="" # to be populated later
> -SRCIP=192.168.1.1
> +SRCIP=192.168.2.1

I mentioned 192.0.2.0/24, which we commonly use in selftests. The range
is meant for examples and documentation, which is not exactly selftests,
but feels like it's not bending the rules too far. And we shouldn't see
the range in the wild.

>  DSTIF="" # to be populated later
> -DSTIP=192.168.1.2
> +DSTIP=192.168.2.2
>  
>  PORT="6666"
>  MSG="netconsole selftest"