netdev - Re: [PATCH net-next 1/2] net: netconsole: selftests: Change the IP subnet

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20241025-fiery-caterpillar-of-acceptance-72cf66@leitao>
Date: Fri, 25 Oct 2024 10:35:13 -0700
From: Breno Leitao <leitao@...ian.org>
To: Petr Machata <petrm@...dia.com>
Cc: kuba@...nel.org, horms@...nel.org, davem@...emloft.net,
	edumazet@...gle.com, pabeni@...hat.com, matttbe@...nel.org,
	Andrew Lunn <andrew+netdev@...n.ch>, Shuah Khan <shuah@...nel.org>,
	thepacketgeek@...il.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, davej@...emonkey.org.uk,
	vlad.wing@...il.com, max@...sevol.com, kernel-team@...a.com,
	aehkn@...hub.one,
	"open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@...r.kernel.org>
Subject: Re: [PATCH net-next 1/2] net: netconsole: selftests: Change the IP
 subnet

On Fri, Oct 25, 2024 at 07:01:59PM +0200, Petr Machata wrote:
> 
> Breno Leitao <leitao@...ian.org> writes:
> 
> > Use a less populated IP range to run the tests, as suggested by Petr in
> > Link: https://lore.kernel.org/netdev/87ikvukv3s.fsf@nvidia.com/.
> >
> > Suggested-by: Petr Machata <petrm@...dia.com>
> > Signed-off-by: Breno Leitao <leitao@...ian.org>
> > ---
> >  tools/testing/selftests/drivers/net/netcons_basic.sh | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/testing/selftests/drivers/net/netcons_basic.sh b/tools/testing/selftests/drivers/net/netcons_basic.sh
> > index 06021b2059b7..4ad1e216c6b0 100755
> > --- a/tools/testing/selftests/drivers/net/netcons_basic.sh
> > +++ b/tools/testing/selftests/drivers/net/netcons_basic.sh
> > @@ -20,9 +20,9 @@ SCRIPTDIR=$(dirname "$(readlink -e "${BASH_SOURCE[0]}")")
> >  
> >  # Simple script to test dynamic targets in netconsole
> >  SRCIF="" # to be populated later
> > -SRCIP=192.168.1.1
> > +SRCIP=192.168.2.1
> 
> I mentioned 192.0.2.0/24, which we commonly use in selftests. The range
> is meant for examples and documentation, which is not exactly selftests,
> but feels like it's not bending the rules too far. And we shouldn't see
> the range in the wild.

True, my mistake. I will update it to 192.0.2.1 and 192.0.2.2.