netdev - RE: [PATCH 1/1] net: dsa: fix tag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87jzdvamk2.fsf@waldekranz.com>
Date: Fri, 25 Oct 2024 23:40:29 +0200
From: Tobias Waldekranz <tobias@...dekranz.com>
To: Hervé Gourmelon <herve.gourmelon@...nops.com>, Andrew
 Lunn
 <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>, Vivien Didelot
 <vivien.didelot@...il.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Vladimir Oltean
 <vladimir.oltean@....com>
Subject: RE: [PATCH 1/1] net: dsa: fix tag_dsa.c for untagged VLANs

On fre, okt 25, 2024 at 16:07, Hervé Gourmelon <herve.gourmelon@...nops.com> wrote:
> On fri, oct 25, 2024 at 17:01, Tobias Waldekranz <tobias@...dekranz.com> wrote:
>>Hi,
>
>>Could you provide the iproute2/bridge commands used to create this
>>bridge?
>
> Sure.
>
> I'm creating a VLAN-filtering bridge:
>
>             ip link add name br2 type bridge vlan_filtering 1 vlan_default_pvid 0
>
> then adding a number of ports to it (with $itemPort being my variable name for the new ports):
>
>             ip link set $itemPort master br2
>             ip link set $itemPort up
>
> then setting up the VLAN on the bridge (with VID = $index_vlan):
>
>             bridge vlan add dev br2 vid $index_vlan self
>             bridge vlan global set dev br2 vid $index_vlan
>             bridge vlan add dev $itemPort vid $index_vlan pvid untagged
>

Alright, nothing out of the ordinary there.

You say that you are "trying to egress untagged traffic on Port0/meth10"
- could you explain how you do that? br2 is a tagged member of the VLAN
in question, so I guess you have stacked a vlan device on top of it?

In your response to Vladimir, you said that you "occasionally" see
packets egress with unexpected tags. Could you give some examples of
flows that work as expected, and flows that have the errant tags?