netdev - RE: [PATCH v5 net-next 09/13] net: enetc: add i.MX95 EMDIO support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB85109E3A5F7D94D8FD00B43B884F2@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Fri, 25 Oct 2024 03:12:29 +0000
From: Wei Fang <wei.fang@....com>
To: Vladimir Oltean <vladimir.oltean@....com>
CC: "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
	<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "robh@...nel.org" <robh@...nel.org>,
	"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
	<conor+dt@...nel.org>, Claudiu Manoil <claudiu.manoil@....com>, Clark Wang
	<xiaoning.wang@....com>, Frank Li <frank.li@....com>,
	"christophe.leroy@...roup.eu" <christophe.leroy@...roup.eu>,
	"linux@...linux.org.uk" <linux@...linux.org.uk>, "bhelgaas@...gle.com"
	<bhelgaas@...gle.com>, "horms@...nel.org" <horms@...nel.org>,
	"imx@...ts.linux.dev" <imx@...ts.linux.dev>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-pci@...r.kernel.org"
	<linux-pci@...r.kernel.org>, "alexander.stein@...tq-group.com"
	<alexander.stein@...tq-group.com>
Subject: RE: [PATCH v5 net-next 09/13] net: enetc: add i.MX95 EMDIO support

> >
> > Signed-off-by: Wei Fang <wei.fang@....com>
> > Reviewed-by: Frank Li <Frank.Li@....com>
> > ---
> > v5: no changes
> > ---
> >  drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c
> b/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c
> > index 2445e35a764a..9968a1e9b5ef 100644
> > --- a/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c
> > +++ b/drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c
> > @@ -2,6 +2,7 @@
> >  /* Copyright 2019 NXP */
> >  #include <linux/fsl/enetc_mdio.h>
> >  #include <linux/of_mdio.h>
> > +#include <linux/pinctrl/consumer.h>
> >  #include "enetc_pf.h"
> >
> >  #define ENETC_MDIO_DEV_ID	0xee01
> > @@ -71,6 +72,8 @@ static int enetc_pci_mdio_probe(struct pci_dev *pdev,
> >  		dev_info(&pdev->dev, "Enabled ERR050089 workaround\n");
> >  	}
> >
> > +	pinctrl_pm_select_default_state(dev);
> > +
> 
> Not an expert on pinctrl by any means.. but is this needed?
> Documentation/driver-api/pin-control.rst says:
> 
> | When a device driver is about to probe the device core will automatically
> | attempt to issue ``pinctrl_get_select_default()`` on these devices.
> | This way driver writers do not need to add any of the boilerplate code
> | of the type found below.
> 
> The documentation is obsolete, because pinctrl_get_select_default()
> doesn't seem to be the current mechanism through which that happens. But
> there is a pinctrl_bind_pins() function in really_probe() which looks
> like it does that job. So.. is this needed?

I think it is no need, I will remove it, thanks.