[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID:
<PAXPR04MB8510ECEB6E78D1FC62358828884F2@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Fri, 25 Oct 2024 03:13:46 +0000
From: Wei Fang <wei.fang@....com>
To: Bjorn Helgaas <helgaas@...nel.org>
CC: "davem@...emloft.net" <davem@...emloft.net>, "edumazet@...gle.com"
<edumazet@...gle.com>, "kuba@...nel.org" <kuba@...nel.org>,
"pabeni@...hat.com" <pabeni@...hat.com>, "robh@...nel.org" <robh@...nel.org>,
"krzk+dt@...nel.org" <krzk+dt@...nel.org>, "conor+dt@...nel.org"
<conor+dt@...nel.org>, Vladimir Oltean <vladimir.oltean@....com>, Claudiu
Manoil <claudiu.manoil@....com>, Clark Wang <xiaoning.wang@....com>, Frank Li
<frank.li@....com>, "christophe.leroy@...roup.eu"
<christophe.leroy@...roup.eu>, "linux@...linux.org.uk"
<linux@...linux.org.uk>, "bhelgaas@...gle.com" <bhelgaas@...gle.com>,
"horms@...nel.org" <horms@...nel.org>, "imx@...ts.linux.dev"
<imx@...ts.linux.dev>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
"alexander.stein@...tq-group.com" <alexander.stein@...tq-group.com>
Subject: RE: [PATCH v5 net-next 08/13] PCI: Add NXP NETC vendor ID and device
IDs
> On Thu, Oct 24, 2024 at 02:53:23PM +0800, Wei Fang wrote:
> > NXP NETC is a multi-function RCiEP and it contains multiple functions,
> > such as EMDIO, PTP Timer, ENETC PF and VF. Therefore, add these device
> > IDs to pci_ids.h.
> >
> > Below are the device IDs and corresponding drivers.
> > PCI_DEVICE_ID_NXP2_ENETC_PF: nxp-enetc4
> > PCI_DEVICE_ID_NXP2_NETC_EMDIO: fsl-enetc-mdio
> > PCI_DEVICE_ID_NXP2_NETC_TIMER: ptp_netc
> > PCI_DEVICE_ID_NXP2_ENETC_VF: fsl-enetc-vf
> >
> > Signed-off-by: Wei Fang <wei.fang@....com>
> > Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>
>
> Please drop my ack. I don't think these meet the spirit of the guidance in
> pci_ids.h, which is there to minimize churn in that file and make backports
> easier:
>
> * Do not add new entries to this file unless the definitions
> * are shared between multiple drivers.
>
> PCI_DEVICE_ID_NXP2_NETC_TIMER and PCI_DEVICE_ID_NXP2_ENETC_VF
> aren't used at all by this series, so they shouldn't be added to pci_ids.h.
>
> PCI_DEVICE_ID_NXP2_NETC_EMDIO is used only by
> drivers/net/ethernet/freescale/enetc/enetc_pci_mdio.c, so it should be defined
> there, not in pci_ids.h.
>
> PCI_DEVICE_ID_NXP2_ENETC_PF is used by enetc.c and enetc4_pf.c, but it looks
> like those are basically part of the same driver, and it could be defined in
> enetc4_hw.h or similar.
>
I was not aware of this, I will remove this patch, thanks.
Powered by blists - more mailing lists