netdev - Re: [PATCH v3] [net-next] igb: Fix 2 typos in comments in igb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZxsnR_fJ5aGKWJTq@Fantasy-Ubuntu>
Date: Thu, 24 Oct 2024 23:06:15 -0600
From: Johnny Park <pjohnny0508@...il.com>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Cc: horms@...nel.org, intel-wired-lan@...ts.osuosl.org,
	netdev@...r.kernel.org, kernel-janitors@...r.kernel.org,
	linux-kernel@...r.kernel.org, anthony.l.nguyen@...el.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, andrew+netdev@...n.ch, pmenzel@...gen.mpg.de
Subject: Re: [PATCH v3] [net-next] igb: Fix 2 typos in comments in igb_main.c

On Thu, Oct 24, 2024 at 10:41:25AM +0200, Przemek Kitszel wrote:
> On 10/24/24 07:45, Johnny Park wrote:
> you should collect Reviewed-by tags, as the one from Simon on v2.
Sorry, I wasn't aware of that rule. For future pathces I'll include reviewed/acked tags.

> for future Intel Ethernet drivers series, please target them to IWL
> (net-next in the Subject becomes iwl-next)
Sorry again, from the other patchworks https://patchwork.ozlabs.org/project/intel-wired-lan/list/ I should have noticed that pattern.  
> >   	ring = q_vector->ring;
> > -	/* intialize ITR */
> > +	/* initialize ITR */
> >   	if (rxr_count) {
> >   		/* rx or rx/tx vector */
> 
> Would be great to have capitalization errors fixed too, Rx, Tx, VF, not
> necessarily in this patch.
That sounds like a good idea, perhaps fixing those will be my next patch.
 
> to reduce traffic, I'm fine with this, to go via any tree:
> Acked-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Thank you for the review!

Regards,
Johnny