[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <060c298c-5961-467a-80dd-947c85207eea@ti.com>
Date: Fri, 25 Oct 2024 11:17:44 +0530
From: Meghana Malladi <m-malladi@...com>
To: Andrew Lunn <andrew@...n.ch>
CC: <vigneshr@...com>, <horms@...nel.org>, <jan.kiszka@...mens.com>,
<diogo.ivo@...mens.com>, <pabeni@...hat.com>, <kuba@...nel.org>,
<edumazet@...gle.com>, <davem@...emloft.net>, <andrew+netdev@...n.ch>,
<linux-kernel@...r.kernel.org>, <vadim.fedorenko@...ux.dev>,
<netdev@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>,
<srk@...com>, Roger Quadros <rogerq@...nel.org>, <danishanwar@...com>
Subject: Re: [PATCH net v2] net: ti: icssg-prueth: Fix 1 PPS sync
On 25/10/24 01:25, Andrew Lunn wrote:
>> +static inline u64 icssg_readq(const void __iomem *addr)
>> +{
>> + return readl(addr) + ((u64)readl(addr + 4) << 32);
>> +}
>> +
>> +static inline void icssg_writeq(u64 val, void __iomem *addr)
>> +{
>> + writel(lower_32_bits(val), addr);
>> + writel(upper_32_bits(val), addr + 4);
>> +}
>
> Could readq() and writeq() be used, rather than your own helpers?
>
> Andrew
>
The addresses we are trying to read here are not 64-bit aligned, hence
using our own helpers to read the 64-bit value.
Regards,
Meghana
Powered by blists - more mailing lists