netdev - Re: [PATCH net-next 12/12] net: homa: create Makefile and Kconfig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202410292151.ozZhCbRL-lkp@intel.com>
Date: Tue, 29 Oct 2024 22:00:48 +0800
From: kernel test robot <lkp@...el.com>
To: John Ousterhout <ouster@...stanford.edu>, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, John Ousterhout <ouster@...stanford.edu>
Subject: Re: [PATCH net-next 12/12] net: homa: create Makefile and Kconfig

Hi John,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/John-Ousterhout/net-homa-define-user-visible-API-for-Homa/20241029-095137
base:   net-next/main
patch link:    https://lore.kernel.org/r/20241028213541.1529-13-ouster%40cs.stanford.edu
patch subject: [PATCH net-next 12/12] net: homa: create Makefile and Kconfig
config: alpha-allyesconfig (https://download.01.org/0day-ci/archive/20241029/202410292151.ozZhCbRL-lkp@intel.com/config)
compiler: alpha-linux-gcc (GCC) 13.3.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241029/202410292151.ozZhCbRL-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202410292151.ozZhCbRL-lkp@intel.com/

All errors (new ones prefixed by >>):

   net/homa/homa_incoming.c: In function 'homa_incoming_sysctl_changed':
>> net/homa/homa_incoming.c:1078:22: error: 'cpu_khz' undeclared (first use in this function)
    1078 |         tmp = (tmp * cpu_khz) / 1000;
         |                      ^~~~~~~
   net/homa/homa_incoming.c:1078:22: note: each undeclared identifier is reported only once for each function it appears in
--
   net/homa/homa_outgoing.c: In function 'homa_outgoing_sysctl_changed':
>> net/homa/homa_outgoing.c:579:46: error: 'cpu_khz' undeclared (first use in this function)
     579 |         homa->cycles_per_kbyte = (8 * (__u64)cpu_khz) / homa->link_mbps;
         |                                              ^~~~~~~
   net/homa/homa_outgoing.c:579:46: note: each undeclared identifier is reported only once for each function it appears in
--
   net/homa/homa_peer.c: In function 'homa_dst_refresh':
>> net/homa/homa_peer.c:189:48: error: 'cpu_khz' undeclared (first use in this function)
     189 |                         dead->gc_time = now + (cpu_khz << 7);
         |                                                ^~~~~~~
   net/homa/homa_peer.c:189:48: note: each undeclared identifier is reported only once for each function it appears in
--
   net/homa/homa_plumbing.c: In function 'homa_softirq':
>> net/homa/homa_plumbing.c:712:61: error: 'cpu_khz' undeclared (first use in this function)
     712 |                 int scaled_ms = (int)(10 * (start - last) / cpu_khz);
         |                                                             ^~~~~~~
   net/homa/homa_plumbing.c:712:61: note: each undeclared identifier is reported only once for each function it appears in
--
   net/homa/homa_utils.c: In function 'homa_spin':
>> net/homa/homa_utils.c:122:36: error: 'cpu_khz' undeclared (first use in this function)
     122 |         end = get_cycles() + (ns * cpu_khz) / 1000000;
         |                                    ^~~~~~~
   net/homa/homa_utils.c:122:36: note: each undeclared identifier is reported only once for each function it appears in


vim +/cpu_khz +1078 net/homa/homa_incoming.c

223bab41c36796 John Ousterhout 2024-10-28  1063  
223bab41c36796 John Ousterhout 2024-10-28  1064  /**
223bab41c36796 John Ousterhout 2024-10-28  1065   * homa_incoming_sysctl_changed() - Invoked whenever a sysctl value is changed;
223bab41c36796 John Ousterhout 2024-10-28  1066   * any input-related parameters that depend on sysctl-settable values.
223bab41c36796 John Ousterhout 2024-10-28  1067   * @homa:    Overall data about the Homa protocol implementation.
223bab41c36796 John Ousterhout 2024-10-28  1068   */
223bab41c36796 John Ousterhout 2024-10-28  1069  void homa_incoming_sysctl_changed(struct homa *homa)
223bab41c36796 John Ousterhout 2024-10-28  1070  {
223bab41c36796 John Ousterhout 2024-10-28  1071  	__u64 tmp;
223bab41c36796 John Ousterhout 2024-10-28  1072  
223bab41c36796 John Ousterhout 2024-10-28  1073  	/* Code below is written carefully to avoid integer underflow or
223bab41c36796 John Ousterhout 2024-10-28  1074  	 * overflow under expected usage patterns. Be careful when changing!
223bab41c36796 John Ousterhout 2024-10-28  1075  	 */
223bab41c36796 John Ousterhout 2024-10-28  1076  
223bab41c36796 John Ousterhout 2024-10-28  1077  	tmp = homa->busy_usecs;
223bab41c36796 John Ousterhout 2024-10-28 @1078  	tmp = (tmp * cpu_khz) / 1000;

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki