netdev - Re: [PATCH net 1/2] net: ethernet: ftgmac100: prevent use after free on unregister when using NCSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f241ba4c7b57ec5142648de2b14cc070b0708823.camel@codeconstruct.com.au>
Date: Tue, 29 Oct 2024 22:10:24 +0800
From: Jeremy Kerr <jk@...econstruct.com.au>
To: Andrew Lunn <andrew@...n.ch>
Cc: Andrew Lunn <andrew+netdev@...n.ch>, "David S. Miller"
 <davem@...emloft.net>,  Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,  Joel Stanley
 <joel@....id.au>, Jacky Chou <jacky_chou@...eedtech.com>, Jacob Keller
 <jacob.e.keller@...el.com>,  netdev@...r.kernel.org
Subject: Re: [PATCH net 1/2] net: ethernet: ftgmac100: prevent use after
 free on unregister when using NCSI

Hi Andrew,

> The order should be reversed, you undo in the opposite order to what
> you do. This is probably not the issue you are having,

No, it's not - the crash occurs before the introduction of the phydev
for ncsi configurations, so the order didn't matter in that case.

> but it does show this driver has ordering issues. If you solve the
> ordering issues, i expect your problem goes away.

"solving the ordering issues" is probably best done by the driver's
maintainers; I have very few facilities for testing the various
configurations that this driver supports.

I'm just sending a couple of minimal patches for crashes I have seen.
All good if you'd like to explore some further driver surgery, but I'm
not the one to do that.

Cheers,

Jeremy