netdev - Re: [PATCH net-next] wwan: core: Pass string literal as format argument of dev_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <173022784550.787364.9831173645509301356.git-patchwork-notify@kernel.org>
Date: Tue, 29 Oct 2024 18:50:45 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Simon Horman <horms@...nel.org>
Cc: loic.poulain@...aro.org, ryazanov.s.a@...il.com,
 johannes@...solutions.net, andrew+netdev@...n.ch, davem@...emloft.net,
 edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com, nathan@...nel.org,
 ndesaulniers@...gle.com, morbo@...gle.com, justinstitt@...gle.com,
 netdev@...r.kernel.org, llvm@...ts.linux.dev
Subject: Re: [PATCH net-next] wwan: core: Pass string literal as format
 argument of dev_set_name()

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Wed, 23 Oct 2024 13:15:28 +0100 you wrote:
> Both gcc-14 and clang-18 report that passing a non-string literal as the
> format argument of dev_set_name() is potentially insecure.
> 
> E.g. clang-18 says:
> 
> drivers/net/wwan/wwan_core.c:442:34: warning: format string is not a string literal (potentially insecure) [-Wformat-security]
>   442 |         return dev_set_name(&port->dev, buf);
>       |                                         ^~~
> drivers/net/wwan/wwan_core.c:442:34: note: treat the string as an argument to avoid this
>   442 |         return dev_set_name(&port->dev, buf);
>       |                                         ^
>       |                                         "%s",
> 
> [...]

Here is the summary with links:
  - [net-next] wwan: core: Pass string literal as format argument of dev_set_name()
    https://git.kernel.org/netdev/net-next/c/3f7f3ef44f4b

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html