netdev - Re: [PATCH net-next v2 2/5] dt-bindings: net: dsa: ksz: add mdio-parent-bus property for internal MDIO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4754b485-05e9-47e5-872e-da5ee31bf9eb@lunn.ch>
Date: Wed, 30 Oct 2024 13:31:16 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Florian Fainelli <f.fainelli@...il.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Woojung Huh <woojung.huh@...rochip.com>,
	Arun Ramadoss <arun.ramadoss@...rochip.com>,
	Conor Dooley <conor+dt@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Rob Herring <robh+dt@...nel.org>, Rob Herring <robh@...nel.org>,
	kernel@...gutronix.de, linux-kernel@...r.kernel.org,
	netdev@...r.kernel.org, UNGLinuxDriver@...rochip.com,
	"Russell King (Oracle)" <linux@...linux.org.uk>,
	devicetree@...r.kernel.org, Marek Vasut <marex@...x.de>
Subject: Re: [PATCH net-next v2 2/5] dt-bindings: net: dsa: ksz: add
 mdio-parent-bus property for internal MDIO

> Yes, this is correct. This can be implemented purely by parsing the
> devicetree. Based on previous experience, I expected you to suggest me
> to implement the validation so i jumped directly to a part of this step.
> 
> Should I implement it based on the devicetree information and validate
> based on HW strapping?

I assume you need to list the PHYs in DT because there is not a 1:1
mapping of port number to MDIO address? If there is a 1:1 mapping,
port 1 has a PHY at MDIO address 1, the DSA core will connect the PHYs
for you, there is no need to list them in DT.

But if strapping can put them anywhere on the bus, this is not true,
and then you need the phy-handle.

I would then suggest DT described the hardware, the PHYs are listed on
the correct MDIO address, and you validate the hardware matches DT
just as a sanity check.

	Andrew