netdev - Re: [PATCH v6 net-next 4/4] ipv6/udp: Add 4-tuple hash for connected socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202411020025.8DrAkT2l-lkp@intel.com>
Date: Sat, 2 Nov 2024 00:47:32 +0800
From: kernel test robot <lkp@...el.com>
To: Philo Lu <lulie@...ux.alibaba.com>, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, willemdebruijn.kernel@...il.com,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, dsahern@...nel.org, horms@...nel.org,
	antony.antony@...unet.com, steffen.klassert@...unet.com,
	linux-kernel@...r.kernel.org, dust.li@...ux.alibaba.com,
	jakub@...udflare.com, fred.cc@...baba-inc.com,
	yubing.qiuyubing@...baba-inc.com
Subject: Re: [PATCH v6 net-next 4/4] ipv6/udp: Add 4-tuple hash for connected
 socket

Hi Philo,

kernel test robot noticed the following build errors:

[auto build test ERROR on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Philo-Lu/net-udp-Add-a-new-struct-for-hash2-slot/20241031-204729
base:   net-next/main
patch link:    https://lore.kernel.org/r/20241031124550.20227-5-lulie%40linux.alibaba.com
patch subject: [PATCH v6 net-next 4/4] ipv6/udp: Add 4-tuple hash for connected socket
config: i386-randconfig-141-20241101 (https://download.01.org/0day-ci/archive/20241102/202411020025.8DrAkT2l-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241102/202411020025.8DrAkT2l-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411020025.8DrAkT2l-lkp@intel.com/

All errors (new ones prefixed by >>):

   net/ipv6/udp.c: In function 'udp_v6_rehash':
>> net/ipv6/udp.c:116:29: error: implicit declaration of function 'udp_ehashfn'; did you mean 'udp6_ehashfn'? [-Werror=implicit-function-declaration]
     116 |                 new_hash4 = udp_ehashfn(sock_net(sk), sk->sk_rcv_saddr, sk->sk_num,
         |                             ^~~~~~~~~~~
         |                             udp6_ehashfn
   cc1: some warnings being treated as errors


vim +116 net/ipv6/udp.c

   107	
   108	void udp_v6_rehash(struct sock *sk)
   109	{
   110		u16 new_hash = ipv6_portaddr_hash(sock_net(sk),
   111						  &sk->sk_v6_rcv_saddr,
   112						  inet_sk(sk)->inet_num);
   113		u16 new_hash4;
   114	
   115		if (ipv6_addr_v4mapped(&sk->sk_v6_rcv_saddr)) {
 > 116			new_hash4 = udp_ehashfn(sock_net(sk), sk->sk_rcv_saddr, sk->sk_num,
   117						sk->sk_daddr, sk->sk_dport);
   118		} else {
   119			new_hash4 = udp6_ehashfn(sock_net(sk), &sk->sk_v6_rcv_saddr, sk->sk_num,
   120						 &sk->sk_v6_daddr, sk->sk_dport);
   121		}
   122	
   123		udp_lib_rehash(sk, new_hash, new_hash4);
   124	}
   125	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki