netdev - Re: [PATCH net-next] bonding: add ESP offload features when slaves support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <45cab833-4bf8-404b-8ffb-252671f1d65c@nvidia.com>
Date: Fri, 1 Nov 2024 10:03:50 +0800
From: Jianbo Liu <jianbol@...dia.com>
To: Jakub Kicinski <kuba@...nel.org>, Tariq Toukan <tariqt@...dia.com>
CC: "David S. Miller" <davem@...emloft.net>, Paolo Abeni <pabeni@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>, Andrew Lunn <andrew+netdev@...n.ch>, "Jay
 Vosburgh" <jv@...sburgh.net>, Andy Gospodarek <andy@...yhouse.net>,
	<netdev@...r.kernel.org>, Saeed Mahameed <saeedm@...dia.com>, Gal Pressman
	<gal@...dia.com>, Leon Romanovsky <leonro@...dia.com>, Boris Pismenny
	<borisp@...dia.com>
Subject: Re: [PATCH net-next] bonding: add ESP offload features when slaves
 support



On 11/1/2024 8:48 AM, Jakub Kicinski wrote:
> On Thu, 24 Oct 2024 19:31:12 +0300 Tariq Toukan wrote:
>> +#ifdef CONFIG_XFRM_OFFLOAD
>> +	if (gso_partial_features & NETIF_F_GSO_ESP)
>> +		bond_dev->gso_partial_features |= NETIF_F_GSO_ESP;
>> +	else
>> +		bond_dev->gso_partial_features &= ~NETIF_F_GSO_ESP;
>> +#endif /* CONFIG_XFRM_OFFLOAD */
> 
> Hiding the block under ifdef is unnecessary.

OK.

> If you worry about the no-lower devs case - add IS_ENABLED()

It will jump to done and bond_dev->gso_partial_features is not changed. 
Seems no need to take care of such case, right?

> to the if condition. The local variable doesn't have to be under
> ifdef either (making it more rev xmas tree compatible)

Sure, I will change in V2.

Thanks!
Jianbo