netdev - Re: [PATCH net-next] bonding: add ESP offload features when slaves support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241031174844.06a5b110@kernel.org>
Date: Thu, 31 Oct 2024 17:48:44 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Tariq Toukan <tariqt@...dia.com>
Cc: "David S. Miller" <davem@...emloft.net>, Paolo Abeni
 <pabeni@...hat.com>, Eric Dumazet <edumazet@...gle.com>, "Andrew Lunn"
 <andrew+netdev@...n.ch>, Jay Vosburgh <jv@...sburgh.net>, "Andy Gospodarek"
 <andy@...yhouse.net>, <netdev@...r.kernel.org>, Saeed Mahameed
 <saeedm@...dia.com>, Gal Pressman <gal@...dia.com>, Leon Romanovsky
 <leonro@...dia.com>, Jianbo Liu <jianbol@...dia.com>, Boris Pismenny
 <borisp@...dia.com>
Subject: Re: [PATCH net-next] bonding: add ESP offload features when slaves
 support

On Thu, 24 Oct 2024 19:31:12 +0300 Tariq Toukan wrote:
> +#ifdef CONFIG_XFRM_OFFLOAD
> +	if (gso_partial_features & NETIF_F_GSO_ESP)
> +		bond_dev->gso_partial_features |= NETIF_F_GSO_ESP;
> +	else
> +		bond_dev->gso_partial_features &= ~NETIF_F_GSO_ESP;
> +#endif /* CONFIG_XFRM_OFFLOAD */

Hiding the block under ifdef is unnecessary.
If you worry about the no-lower devs case - add IS_ENABLED()
to the if condition. The local variable doesn't have to be under
ifdef either (making it more rev xmas tree compatible)
-- 
pw-bot: cr