netdev - Re: [PATCH net-next v1 1/1] nfc: mrvl: Don't use "proxy" headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2dc98d01-6353-478c-b6ad-d6eac63c53da@kernel.org>
Date: Sat, 2 Nov 2024 09:00:04 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v1 1/1] nfc: mrvl: Don't use "proxy" headers

On 01/11/2024 09:39, Andy Shevchenko wrote:
> Update header inclusions to follow IWYU (Include What You Use)
> principle.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
> ---
>  drivers/nfc/nfcmrvl/uart.c | 9 +++++++--
>  1 file changed, 7 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/nfc/nfcmrvl/uart.c b/drivers/nfc/nfcmrvl/uart.c
> index 956ae92f7573..2037cd6d4f4f 100644
> --- a/drivers/nfc/nfcmrvl/uart.c
> +++ b/drivers/nfc/nfcmrvl/uart.c
> @@ -5,11 +5,16 @@
>   * Copyright (C) 2015, Marvell International Ltd.
>   */
>  
> -#include <linux/module.h>
>  #include <linux/delay.h>
> -#include <linux/of_gpio.h>
> +#include <linux/device.h>
> +#include <linux/err.h>
> +#include <linux/module.h>
> +#include <linux/of.h>
> +#include <linux/printk.h>

Do we really include printk? It's almost everywhere and pulled by kernel.h.

I assume you checked rest of the nfcmrvl files for similar cleanups, so
anyway:

Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof