netdev - RE: [RFC net-next v01 1/1] net: hinic3: Add a driver for Huawei 3rd gen NIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <000001db2dec$10d92680$328b7380$@huawei.com>
Date: Sun, 3 Nov 2024 14:29:27 +0200
From: Gur Stavi <gur.stavi@...wei.com>
To: 'Jakub Kicinski' <kuba@...nel.org>
CC: "Gongfan (Eric, Chip)" <gongfan1@...wei.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Cai Huoqing
	<cai.huoqing@...ux.dev>, "Guoxin (D)" <guoxin09@...wei.com>, shenchenyang
	<shenchenyang1@...ilicon.com>, "zhoushuai (A)" <zhoushuai28@...wei.com>,
	"Wulike (Collin)" <wulike1@...wei.com>, "shijing (A)" <shijing34@...wei.com>,
	Meny Yossefi <meny.yossefi@...wei.com>
Subject: RE: [RFC net-next v01 1/1] net: hinic3: Add a driver for Huawei 3rd gen NIC

> On Wed, 30 Oct 2024 14:25:47 +0200 Gur Stavi wrote:
> >  50 files changed, 18058 insertions(+)
> 
> 4kLoC is the right ballpark to target for the initial submission.
> Please cut this down and submit a minimal driver, then add the
> features.

Ack.
There is indeed code which is not critical to basic Ethernet functionality
that can be postponed to later.

Our HW management infrastructure is rather large and contains 2 separate
mechanisms (cmdq+mbox). While I hope we can trim the driver to a VF-only
version with no ethtool support that will fit the 10KLoC ballpark, the 4KLoC
goal is probably unrealistic for a functional driver.

Is it valid to submit a non-functional kernel module and make it functional
with follow-up submissions? For example:
Submission 1: TX+RX logic
Submission 2: Device management infrastructure
Submission 3: PCI device registration and netdev creation

Some initial submission cases we studied before our submission:

Amazon/ena: 10858 insertions
https://lore.kernel.org/netdev/1470827002-23081-1-git-send-email-netanel@ann
apurnalabs.com/

Microsoft/mana: 6168 insertions
https://lore.kernel.org/netdev/20210416060705.21998-1-decui@microsoft.com/

Huawei/hinic: 12728 insertions
https://lore.kernel.org/netdev/cover.1503330613.git.aviad.krawczyk@huawei.co
m/