netdev - Re: [RFC net-next v01 1/1] net: hinic3: Add a driver for Huawei 3rd gen NIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <661620c5-acdd-43df-8316-da01b0d2f2b3@lunn.ch>
Date: Sun, 3 Nov 2024 19:54:30 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Gur Stavi <gur.stavi@...wei.com>
Cc: 'Jakub Kicinski' <kuba@...nel.org>,
	"Gongfan (Eric, Chip)" <gongfan1@...wei.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Cai Huoqing <cai.huoqing@...ux.dev>,
	"Guoxin (D)" <guoxin09@...wei.com>,
	shenchenyang <shenchenyang1@...ilicon.com>,
	"zhoushuai (A)" <zhoushuai28@...wei.com>,
	"Wulike (Collin)" <wulike1@...wei.com>,
	"shijing (A)" <shijing34@...wei.com>,
	Meny Yossefi <meny.yossefi@...wei.com>
Subject: Re: [RFC net-next v01 1/1] net: hinic3: Add a driver for Huawei 3rd
 gen NIC

On Sun, Nov 03, 2024 at 02:29:27PM +0200, Gur Stavi wrote:
> > On Wed, 30 Oct 2024 14:25:47 +0200 Gur Stavi wrote:
> > >  50 files changed, 18058 insertions(+)
> > 
> > 4kLoC is the right ballpark to target for the initial submission.
> > Please cut this down and submit a minimal driver, then add the
> > features.
> 
> Ack.
> There is indeed code which is not critical to basic Ethernet functionality
> that can be postponed to later.
> 
> Our HW management infrastructure is rather large and contains 2 separate
> mechanisms (cmdq+mbox). While I hope we can trim the driver to a VF-only
> version with no ethtool support that will fit the 10KLoC ballpark, the 4KLoC
> goal is probably unrealistic for a functional driver.

It is really all about making you code attractive to reviewers. No
reviewer is likely to have time to review a single 10KLoc patch. A
reviewer is more likely to look at the code if it is broken up into 15
smaller patches, each one which can be reviewed in a coffee break
etc. Also, reviewers have interests. I personally have no interest in
mailbox APIs, actually moving frames around, etc. I want to easily
find the ethtool code, have you got pause wrong like nearly everybody
does, are the statistics correctly broken up into the standard groups,
are you abusing debugfs? Having little patches with good subject lines
will draw me towards the patches i want to review.

10KLoC is still on the large size. Can you throw VF out, it is just a
plain borring single function device, like the good old e1000e?

	Andrew