netdev - Re: [PATCH] ipv6: ip6_fib: fix null-pointer dereference in ipv6_route_native_seq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241103075641.2ea347cd@kernel.org>
Date: Sun, 3 Nov 2024 07:56:41 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Yi Zou <03zouyi09.25@...il.com>
Cc: davem@...emloft.net, 21210240012@...udan.edu.cn,
 21302010073@...udan.edu.cn, dsahern@...nel.org, edumazet@...gle.com,
 pabeni@...hat.com, Markus.Elfring@....de, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ipv6: ip6_fib: fix null-pointer dereference in
 ipv6_route_native_seq_show()

On Sun,  3 Nov 2024 04:08:20 +0800 Yi Zou wrote:
> Check if fib6_nh is non-NULL before accessing fib6_nh->fib_nh_gw_family
> in ipv6_route_native_seq_show() to prevent a null-pointer dereference.
> Assign dev as dev = fib6_nh ? fib6_nh->fib_nh_dev : NULL to ensure safe
> handling when nexthop_fib6_nh(rt->nh) returns NULL.

Are you just sending this patch because nexthop_fib6_nh() may return
NULL? Not sure it can happen since we know we're walking a v6-only
table here.

Please try to crash it and add a stack trace to the commit message. 

BTW your last posting was white space damaged. Stick to git send-email