netdev - Re: [PATCH net-next v1 2/2] netlink: specs: Add a spec for FIB rule management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <m234k6vt29.fsf@gmail.com>
Date: Tue, 05 Nov 2024 11:06:06 +0000
From: Donald Hunter <donald.hunter@...il.com>
To: Ido Schimmel <idosch@...sch.org>
Cc: netdev@...r.kernel.org,  Jakub Kicinski <kuba@...nel.org>,  "David S.
 Miller" <davem@...emloft.net>,  Eric Dumazet <edumazet@...gle.com>,  Paolo
 Abeni <pabeni@...hat.com>,  Simon Horman <horms@...nel.org>,
  donald.hunter@...hat.com,  gnault@...hat.com
Subject: Re: [PATCH net-next v1 2/2] netlink: specs: Add a spec for FIB rule
 management

Ido Schimmel <idosch@...sch.org> writes:

>
> Donald,
>
> We added a new DSCP attribute in the last release. Can you please
> include it in the spec? Tested the following diff [1].
>
> Thanks!
>
> [1]

Good catch, thanks! Diff applied for v2.

> diff --git a/Documentation/netlink/specs/rt_rule.yaml b/Documentation/netlink/specs/rt_rule.yaml
> index 736bcdb25738..8d1a594e851d 100644
> --- a/Documentation/netlink/specs/rt_rule.yaml
> +++ b/Documentation/netlink/specs/rt_rule.yaml
> @@ -169,6 +169,9 @@ attribute-sets:
>          name: dport-range
>          type: binary
>          struct: fib-rule-port-range
> +      -
> +        name: dscp
> +        type: u8
>  
>  operations:
>    enum-model: directional
> @@ -199,6 +202,7 @@ operations:
>              - ip-proto
>              - sport-range
>              - dport-range
> +            - dscp
>      -
>        name: newrule-ntf
>        doc: Notify a rule creation