netdev - Re: [PATCH net-next v1 2/2] netlink: specs: Add a spec for FIB rule management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m2y11yueb1.fsf@gmail.com>
Date: Tue, 05 Nov 2024 11:10:10 +0000
From: Donald Hunter <donald.hunter@...il.com>
To: Stanislav Fomichev <stfomichev@...il.com>
Cc: netdev@...r.kernel.org,  Jakub Kicinski <kuba@...nel.org>,  "David S.
 Miller" <davem@...emloft.net>,  Eric Dumazet <edumazet@...gle.com>,  Paolo
 Abeni <pabeni@...hat.com>,  Simon Horman <horms@...nel.org>,
  donald.hunter@...hat.com
Subject: Re: [PATCH net-next v1 2/2] netlink: specs: Add a spec for FIB rule
 management

Stanislav Fomichev <stfomichev@...il.com> writes:

>> +    name: fib-rule-uid-range
>> +    type: struct
>> +    members:
>> +      -
>> +        name: start
>> +        type: u16
>> +      -
>> +        name: end
>> +        type: u16
>
> Should be u32?
>
> struct fib_rule_uid_range {
>         __u32           start;
>         __u32           end;
> };

Ah, well spotted. Looks like I didn't fix up a copy-paste from
fib-rule-port-range.

Thanks!

> Otherwise, both patches look good:
>
> Acked-by: Stanislav Fomichev <sdf@...ichev.me>