netdev - Re: [PATCH net] net: txgbe: fix lost GPIO interrupt

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0312f05a-d2b1-466d-a0a2-9279544466bd@lunn.ch>
Date: Wed, 6 Nov 2024 19:01:44 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Jiawen Wu <jiawenwu@...stnetic.com>
Cc: andrew+netdev@...n.ch, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, linux@...linux.org.uk,
	horms@...nel.org, netdev@...r.kernel.org, mengyuanlou@...-swift.com,
	duanqiangwen@...-swift.com
Subject: Re: [PATCH net] net: txgbe: fix lost GPIO interrupt

On Wed, Nov 06, 2024 at 06:17:17PM +0800, Jiawen Wu wrote:
> Sometimes when clearing interrupts for workaround in txgbe_up_complete(),
> the GPIO interrupt is lost once due to the interrupt polarity is
> consistent with the GPIO state. It causes the SFP state cannot be updated
> immediately. That is, SFP driver can only get into the correct state if
> the GPIO state changes again.

If i remember correctly, the basic issue is that your hardware cannot
do IRQ_TYPE_EDGE_BOTH? You try to fake it by configuring for
IRQ_TYPE_EDGE_RISING when the GPIO is low, IRQ_TYPE_EDGE_FALLING when
the GPIO is high. And then hope you can handle the interrupt fast
enough you don't miss an edge?

Maybe you should just accept the interrupt controller hardware is
broken, and let the SFP driver poll the GPIO? Do you really need to
know in less than a second the SFP has been ejected, or changed is LOS
status?

	Andrew