netdev - Re: [PATCH net-next v2 5/8] net: ip_gre: Add netns

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241107075943.78bb160c@kernel.org>
Date: Thu, 7 Nov 2024 07:59:43 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Xiao Liang <shaw.leon@...il.com>
Cc: Eric Dumazet <edumazet@...gle.com>, netdev@...r.kernel.org,
 linux-kselftest@...r.kernel.org, Kuniyuki Iwashima <kuniyu@...zon.com>,
 "David S. Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>,
 Paolo Abeni <pabeni@...hat.com>, Ido Schimmel <idosch@...dia.com>, Andrew
 Lunn <andrew+netdev@...n.ch>, Simon Horman <horms@...nel.org>, Donald
 Hunter <donald.hunter@...il.com>, Shuah Khan <shuah@...nel.org>, Jiri Pirko
 <jiri@...nulli.us>, Hangbin Liu <liuhangbin@...il.com>
Subject: Re: [PATCH net-next v2 5/8] net: ip_gre: Add netns_atomic module
 parameter

On Thu, 7 Nov 2024 22:11:24 +0800 Xiao Liang wrote:
> > Instead, add new rtnetlink attributes ?  
> 
> It is to control driver behavior at rtnl_ops registration time. I
> think rtnetlink
> attributes are too late for that, maybe? Can't think of a way other than
> module parameters or register separate ops. Any suggestions?

Step back from the implementation you have a little, forget that there
is a boolean in rtnl_link_ops. User makes a request to spawn an
interface, surely a flag inside that request can dictate how the netns
attrs are interpreted.