netdev - Re: [PATCH net-next v2 7/8] tools/net/ynl: Add retry limit for async notification

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241107080420.6a5a5243@kernel.org>
Date: Thu, 7 Nov 2024 08:04:20 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Donald Hunter <donald.hunter@...il.com>
Cc: Xiao Liang <shaw.leon@...il.com>, netdev@...r.kernel.org,
 linux-kselftest@...r.kernel.org, Kuniyuki Iwashima <kuniyu@...zon.com>,
 "David S. Miller" <davem@...emloft.net>, David Ahern <dsahern@...nel.org>,
 Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Ido
 Schimmel <idosch@...dia.com>, Andrew Lunn <andrew+netdev@...n.ch>, Simon
 Horman <horms@...nel.org>, Shuah Khan <shuah@...nel.org>, Jiri Pirko
 <jiri@...nulli.us>, Hangbin Liu <liuhangbin@...il.com>
Subject: Re: [PATCH net-next v2 7/8] tools/net/ynl: Add retry limit for
 async notification

On Thu,  7 Nov 2024 21:30:02 +0800 Xiao Liang wrote:
> Since commit 1bf70e6c3a53 ("tools/net/ynl: improve async notification
> handling"), check_ntf() would block indefinitely if there's no messages.
> In some cases we want to set a limit on waiting time. This patch adds
> max_reties parameter check_ntf(), and makes it stop when no message is
> recievied in that number of consecutive retries.

Looking at 1bf70e6c3a53 again I wonder if we should revert it, sort of,
and add its logic back as a new function called poll_nft?

The thing is C YNL has check_ntf too - ynl_ntf_check() and it has the
old semantics. Would be nice for similarly named functions to behave
the same across languages.

WDYT Donald? Sorry for not thinking about this earlier.

Xiao, feel free to submit this separately from the series.