netdev - Re: [PATCH net-next 3/4] net: phy: broadcom: use genphy_c45_an_config_eee_aneg in bcm_config_lre

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d3def42-26ff-4be9-b5a3-990078e91c5f@broadcom.com>
Date: Thu, 7 Nov 2024 09:48:50 -0800
From: Florian Fainelli <florian.fainelli@...adcom.com>
To: Heiner Kallweit <hkallweit1@...il.com>, Paolo Abeni <pabeni@...hat.com>,
 Jakub Kicinski <kuba@...nel.org>, Eric Dumazet <edumazet@...gle.com>,
 Andrew Lunn <andrew@...n.ch>, David Miller <davem@...emloft.net>,
 Russell King - ARM Linux <linux@...linux.org.uk>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
 Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>
Subject: Re: [PATCH net-next 3/4] net: phy: broadcom: use
 genphy_c45_an_config_eee_aneg in bcm_config_lre_aneg

On 11/6/24 12:24, Heiner Kallweit wrote:
> bcm_config_lre_aneg() is the only user of genphy_config_eee_advert(),
> therefore use genphy_c45_an_config_eee_aneg() instead. The resulting
> functionality is equivalent, and bcm_config_lre_aneg() follows the
> structure of __genphy_config_aneg().
> In a follow-up step genphy_config_eee_advert() can be removed.
> 
> Note: We preserve the current behavior to ignore errors.
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>

Thanks, this also makes the driver future proof with respect to 2.5/5G 
modes which was not the case before.
-- 
Florian