netdev - Re: [net-next PATCH] net: dsa: add devm_dsa_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <672e7a61.050a0220.1d1399.6d31@mx.google.com>
Date: Fri, 8 Nov 2024 21:53:48 +0100
From: Christian Marangi <ansuelsmth@...il.com>
To: Andrew Lunn <andrew@...n.ch>
Cc: Florian Fainelli <f.fainelli@...il.com>,
	Vladimir Oltean <olteanv@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Marion & Christophe JAILLET <christophe.jaillet@...adoo.fr>
Subject: Re: [net-next PATCH] net: dsa: add devm_dsa_register_switch()

On Fri, Nov 08, 2024 at 09:35:32PM +0100, Andrew Lunn wrote:
> > +int devm_dsa_register_switch(struct device *dev, struct dsa_switch *ds)
> > +{
> > +	int err;
> > +
> > +	err = dsa_register_switch(ds);
> > +	if (err)
> > +		return err;
> > +
> > +	return devm_add_action_or_reset(dev, devm_dsa_unregister_switch, ds);
> > +}
> > +EXPORT_SYMBOL_GPL(dsa_register_switch);
> 
> This looks to be the wrong function name.
>

Ah... Anyway aside from this, is the feature OK? Questioning why it
wasn't proposed early...

> 
> ---
> pw-bot: cr
> 

-- 
	Ansuel