netdev - Re: [PATCH net-next 01/15] ice: Add E830 checksum offload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7aad3452-a08c-4c28-9bd9-3fa1cd1f9b39@intel.com>
Date: Thu, 7 Nov 2024 17:37:41 -0800
From: "Greenwalt, Paul" <paul.greenwalt@...el.com>
To: Jakub Kicinski <kuba@...nel.org>, Tony Nguyen <anthony.l.nguyen@...el.com>
CC: <davem@...emloft.net>, <pabeni@...hat.com>, <edumazet@...gle.com>,
	<andrew+netdev@...n.ch>, <netdev@...r.kernel.org>, Alice Michael
	<alice.michael@...el.com>, Eric Joyner <eric.joyner@...el.com>, "Alexander
 Lobakin" <aleksander.lobakin@...el.com>, Pucha Himasekhar Reddy
	<himasekharx.reddy.pucha@...el.com>
Subject: Re: [PATCH net-next 01/15] ice: Add E830 checksum offload support



On 11/6/2024 6:08 PM, Jakub Kicinski wrote:
> On Tue,  5 Nov 2024 14:23:35 -0800 Tony Nguyen wrote:
>> +static netdev_features_t
>> +ice_fix_features_gcs(struct net_device *netdev, netdev_features_t features)
>> +{
>> +	if (!((features & NETIF_F_HW_CSUM) && (features & NETIF_F_ALL_TSO)))
>> +		return features;
>> +
>> +	if (netdev->features & NETIF_F_HW_CSUM) {
>> +		netdev_warn(netdev, "Dropping TSO. TSO and HW checksum are mutually exclusive.\n");
>> +		features &= ~NETIF_F_ALL_TSO;
>> +	} else {
>> +		netdev_warn(netdev, "Dropping HW checksum. TSO and HW checksum are mutually exclusive.\n");
>> +		features &= ~NETIF_F_HW_CSUM;
>> +	}
> 
> why dropping what the user requested with a warning and not just return
> an error from ice_set_features()?

Hi Jakub,

I took this approach of reducing the feature set to resolve the device
NETIF_F_HW_CSUM and NETIF_F_ALL_TSO feature limitation, which seemed
consistent with the guidance in the netdev-features documentation.

Thanks,
Paul