netdev - Re: [PATCH net-next 01/15] ice: Add E830 checksum offload support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241107201427.28e00918@kernel.org>
Date: Thu, 7 Nov 2024 20:14:27 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: "Greenwalt, Paul" <paul.greenwalt@...el.com>
Cc: Tony Nguyen <anthony.l.nguyen@...el.com>, <davem@...emloft.net>,
 <pabeni@...hat.com>, <edumazet@...gle.com>, <andrew+netdev@...n.ch>,
 <netdev@...r.kernel.org>, Alice Michael <alice.michael@...el.com>, Eric
 Joyner <eric.joyner@...el.com>, "Alexander Lobakin"
 <aleksander.lobakin@...el.com>, Pucha Himasekhar Reddy
 <himasekharx.reddy.pucha@...el.com>
Subject: Re: [PATCH net-next 01/15] ice: Add E830 checksum offload support

On Thu, 7 Nov 2024 17:37:41 -0800 Greenwalt, Paul wrote:
> > why dropping what the user requested with a warning and not just return
> > an error from ice_set_features()?  
> 
> I took this approach of reducing the feature set to resolve the device
> NETIF_F_HW_CSUM and NETIF_F_ALL_TSO feature limitation, which seemed
> consistent with the guidance in the netdev-features documentation.

My understanding of that guidance is that it is for "positive"
dependencies. Feature A requires feature B, so if feature B is
cleared so should the feature A. Here we have a feature conflict.