netdev - Re: [iwl-next v7 2/9] ice: devlink PF MSI-X max and min parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZzMYqp8A59lfnLa9@mev-dev.igk.intel.com>
Date: Tue, 12 Nov 2024 09:58:18 +0100
From: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
To: Michal Schmidt <mschmidt@...hat.com>
Cc: intel-wired-lan@...ts.osuosl.org, netdev@...r.kernel.org,
	pawel.chmielewski@...el.com, sridhar.samudrala@...el.com,
	jacob.e.keller@...el.com, pio.raczynski@...il.com,
	konrad.knitter@...el.com, marcin.szycik@...el.com,
	wojciech.drewek@...el.com, nex.sw.ncis.nat.hpm.dev@...el.com,
	przemyslaw.kitszel@...el.com, jiri@...nulli.us, horms@...nel.org,
	David.Laight@...lab.com, pmenzel@...gen.mpg.de
Subject: Re: [iwl-next v7 2/9] ice: devlink PF MSI-X max and min parameter

On Mon, Nov 11, 2024 at 12:44:11PM +0100, Michal Schmidt wrote:
> On Mon, Nov 4, 2024 at 1:13 PM Michal Swiatkowski
> <michal.swiatkowski@...ux.intel.com> wrote:
> >
> > Use generic devlink PF MSI-X parameter to allow user to change MSI-X
> > range.
> >
> > Add notes about this parameters into ice devlink documentation.
> >
> > Signed-off-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> > ---
> >  Documentation/networking/devlink/ice.rst      | 11 +++
> >  .../net/ethernet/intel/ice/devlink/devlink.c  | 83 ++++++++++++++++++-
> >  drivers/net/ethernet/intel/ice/ice.h          |  7 ++
> >  drivers/net/ethernet/intel/ice/ice_irq.c      |  7 ++
> >  4 files changed, 107 insertions(+), 1 deletion(-)
> >
> [...]
> > @@ -1648,6 +1710,7 @@ void ice_devlink_unregister(struct ice_pf *pf)
> >  int ice_devlink_register_params(struct ice_pf *pf)
> >  {
> >         struct devlink *devlink = priv_to_devlink(pf);
> > +       union devlink_param_value value;
> >         struct ice_hw *hw = &pf->hw;
> >         int status;
> >
> > @@ -1656,11 +1719,27 @@ int ice_devlink_register_params(struct ice_pf *pf)
> >         if (status)
> >                 return status;
> >
> > +       status = devl_params_register(devlink, ice_dvl_msix_params,
> > +                                     ARRAY_SIZE(ice_dvl_msix_params));
> > +       if (status)
> > +               return status;
> > +
> >         if (hw->func_caps.common_cap.tx_sched_topo_comp_mode_en)
> >                 status = devl_params_register(devlink, ice_dvl_sched_params,
> >                                               ARRAY_SIZE(ice_dvl_sched_params));
> > +       if (status)
> > +               return status;
> 
> Error handling looks wrong in this function.
> You have to unwind the registration of the params from above or they will leak.
> Sorry I did not notice this earlier.
> 

Right, I  will send fixed version.
Thanks for reviewing,
Michal

> Michal
>