netdev - RE: [Intel-wired-lan] [iwl-next v7 8/9] ice: simplify VF MSI-X managing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ0PR11MB5865B58D55FAB6603E533DBA8F5A2@SJ0PR11MB5865.namprd11.prod.outlook.com>
Date: Wed, 13 Nov 2024 09:20:22 +0000
From: "Romanowski, Rafal" <rafal.romanowski@...el.com>
To: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "pmenzel@...gen.mpg.de" <pmenzel@...gen.mpg.de>, "Drewek, Wojciech"
	<wojciech.drewek@...el.com>, "Szycik, Marcin" <marcin.szycik@...el.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Knitter, Konrad"
	<konrad.knitter@...el.com>, "Chmielewski, Pawel"
	<pawel.chmielewski@...el.com>, "horms@...nel.org" <horms@...nel.org>,
	"David.Laight@...LAB.COM" <David.Laight@...LAB.COM>, NEX SW NCIS NAT HPM DEV
	<nex.sw.ncis.nat.hpm.dev@...el.com>, "pio.raczynski@...il.com"
	<pio.raczynski@...il.com>, "Samudrala, Sridhar"
	<sridhar.samudrala@...el.com>, "Keller, Jacob E" <jacob.e.keller@...el.com>,
	"jiri@...nulli.us" <jiri@...nulli.us>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>
Subject: RE: [Intel-wired-lan] [iwl-next v7 8/9] ice: simplify VF MSI-X
 managing

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Michal
> Swiatkowski
> Sent: Monday, November 4, 2024 1:14 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: pmenzel@...gen.mpg.de; Drewek, Wojciech <wojciech.drewek@...el.com>;
> Szycik, Marcin <marcin.szycik@...el.com>; netdev@...r.kernel.org; Knitter,
> Konrad <konrad.knitter@...el.com>; Chmielewski, Pawel
> <pawel.chmielewski@...el.com>; horms@...nel.org;
> David.Laight@...LAB.COM; NEX SW NCIS NAT HPM DEV
> <nex.sw.ncis.nat.hpm.dev@...el.com>; pio.raczynski@...il.com; Samudrala,
> Sridhar <sridhar.samudrala@...el.com>; Keller, Jacob E
> <jacob.e.keller@...el.com>; jiri@...nulli.us; Kitszel, Przemyslaw
> <przemyslaw.kitszel@...el.com>
> Subject: [Intel-wired-lan] [iwl-next v7 8/9] ice: simplify VF MSI-X managing
> 
> After implementing pf->msix.max field, base vector for other use cases (like VFs)
> can be fixed. This simplify code when changing MSI-X amount on particular VF,
> because there is no need to move a base vector.
> 
> A fixed base vector allows to reserve vectors from the beginning instead of from
> the end, which is also simpler in code.
> 
> Store total and rest value in the same struct as max and min for PF.
> Move tracking vectors from ice_sriov.c to ice_irq.c as it can be also use for other
> none PF use cases (SIOV).
> 
> Signed-off-by: Michal Swiatkowski <michal.swiatkowski@...ux.intel.com>
> ---
>  drivers/net/ethernet/intel/ice/ice.h       |  10 +-
>  drivers/net/ethernet/intel/ice/ice_irq.c   |  75 +++++++---
>  drivers/net/ethernet/intel/ice/ice_irq.h   |  13 +-
>  drivers/net/ethernet/intel/ice/ice_sriov.c | 154 ++-------------------
>  4 files changed, 79 insertions(+), 173 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/ice/ice.h
> b/drivers/net/ethernet/intel/ice/ice.h
> index 14a90c916d43..7200d6042590 100644
> --- a/drivers/net/ethernet/intel/ice/ice.h
> +++ b/drivers/net/ethernet/intel/ice/ice.h
> @@ -544,6 +544,8 @@ struct ice_pf_msix {


Tested-by: Rafal Romanowski <rafal.romanowski@...el.com>