netdev - Testing selectable timestamping - where are the tools for this feature?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZzS7wWx4lREiOgL3@shell.armlinux.org.uk>
Date: Wed, 13 Nov 2024 14:46:25 +0000
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: Kory Maincent <kory.maincent@...tlin.com>
Cc: Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Subject: Testing selectable timestamping - where are the tools for this
 feature?

Hi Kory,

I've finally found some cycles (and time when I'm next to the platform)
to test the selectable timestamping feature. However, I'm struggling to
get it to work.

In your email
https://lore.kernel.org/20240709-feature_ptp_netnext-v17-0-b5317f50df2a@bootlin.com/
you state that "You can test it with the ethtool source on branch
feature_ptp of: https://github.com/kmaincent/ethtool". I cloned this
repository, checked out the feature_ptp branch, and while building
I get the following warnings:

netlink/desc-ethtool.c:241:37: warning: ‘__ts_desc’ defined but not used [-Wunus
ed-const-variable=]
  241 | static const struct pretty_nla_desc __ts_desc[] = {
      |                                     ^~~~~~~~~
netlink/ts.c: In function ‘ts_get_reply_cb’:
netlink/ts.c:23:14: warning: unused variable ‘str’ [-Wunused-variable]
   23 |         char str[10] = {'\0'};
      |              ^~~
ethtool.c:4865:12: warning: ‘do_set_ptp’ defined but not used [-Wunused-functio ]
 4865 | static int do_set_ptp(struct cmd_context *ctx)
      |            ^~~~~~~~~~
ethtool.c:4839:12: warning: ‘do_get_ptp’ defined but not used [-Wunused-functio ]
 4839 | static int do_get_ptp(struct cmd_context *ctx)
      |            ^~~~~~~~~~
ethtool.c:4817:12: warning: ‘do_list_ptp’ defined but not used [-Wunused-function]
 4817 | static int do_list_ptp(struct cmd_context *ctx)
      |            ^~~~~~~~~~~

My conclusion is... your ethtool sources for testing this feature are
broken, or this is no longer the place to test this feature.

Presumably there _is_ something somewhere that allows one to exercise
this new code that Jakub merged on July 15th (commit 30b356005048)?
Please could you point me in the appropriate direction ASAP - time is
very short if I'm going to give this a test on the setup where both
the MAC and PHY support PTP. Essentially, this afternoon - or its
going to be at least a month before the next opportunity.

Thanks.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!