netdev - Re: Testing selectable timestamping - where are the tools for this feature?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241113161602.2d36080c@kmaincent-XPS-13-7390>
Date: Wed, 13 Nov 2024 16:16:02 +0100
From: Kory Maincent <kory.maincent@...tlin.com>
To: "Russell King (Oracle)" <linux@...linux.org.uk>
Cc: Jakub Kicinski <kuba@...nel.org>, netdev@...r.kernel.org
Subject: Re: Testing selectable timestamping - where are the tools for this
 feature?

Hello Russell,

On Wed, 13 Nov 2024 14:46:25 +0000
"Russell King (Oracle)" <linux@...linux.org.uk> wrote:

> Hi Kory,
> 
> I've finally found some cycles (and time when I'm next to the platform)
> to test the selectable timestamping feature. However, I'm struggling to
> get it to work.
> 
> In your email
> https://lore.kernel.org/20240709-feature_ptp_netnext-v17-0-b5317f50df2a@bootlin.com/
> you state that "You can test it with the ethtool source on branch
> feature_ptp of: https://github.com/kmaincent/ethtool". I cloned this
> repository, checked out the feature_ptp branch, and while building
> I get the following warnings:
> 
> My conclusion is... your ethtool sources for testing this feature are
> broken, or this is no longer the place to test this feature.

Yeah, it was for v3 of the patch series. It didn't follow up to v19, I am using
ynl tool which is the easiest way to test it.
As there were a lot of changes along the way, updating ethtool every time was
not a good idea.

Use ynl tool. Commands are described in the last patch of the series:
https://lore.kernel.org/all/20241030-feature_ptp_netnext-v19-10-94f8aadc9d5c@bootlin.com/

You simply need to install python python-yaml and maybe others python
subpackages.
Copy the tool "tools/net/ynl" and the specs "Documentation/netlink/" on the
board.

Then run the ynl commands.

> Presumably there _is_ something somewhere that allows one to exercise
> this new code that Jakub merged on July 15th (commit 30b356005048)?

You can indeed test this merge with mainline ethtool.
Specially the commit 2dd356005901 which changes the default hwtstamp to MAC for
newly supported PHY PTP as you requested.
With your marvell PTP support patch it should still report and use ts info from
the MAC.

Regards,
-- 
Köry Maincent, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com