[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <07e69b19-36c2-ece4-734f-e2189b950cab@gmail.com>
Date: Wed, 13 Nov 2024 03:30:05 +0000
From: Edward Cree <ecree.xilinx@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Joe Damato <jdamato@...tly.com>, Daniel Xu <dxu@...uu.xyz>,
davem@...emloft.net, mkubecek@...e.cz, martin.lau@...ux.dev,
netdev@...r.kernel.org, kernel-team@...a.com
Subject: Re: [PATCH ethtool-next] rxclass: Make output for RSS context action
explicit
On 12/11/2024 15:24, Jakub Kicinski wrote:
> Hm, interesting idea...
> Practically speaking I think it introduces complexity and I'm not sure
> anyone will actually benefit (IOW why would anyone want to keep /
> create context for inactive queues?).
Conceivably to save re-configuring them next time they increase the
queues again? But I suppose anyone doing that kind of complicated
demand-flexible tuning will be using some kind of userland software
that can automate that.
Anyway I don't have a dog in this fight as sfc doesn't support ethtool
set-channels. (Which will make it difficult for me to test this; had
I better extend netdevsim to support RSS & rxnfc?)
> My gut feeling is that we should just leave a comment for posterity
> somewhere in the code but continue to validate both based on rules
> and based on "direct" context membership.
Will do.
Powered by blists - more mailing lists