netdev - Re: [PATCH V1 1/2] bnxt_en: Add TPH support in BNXT driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241115140434.50457691@kernel.org>
Date: Fri, 15 Nov 2024 14:04:34 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: <bhelgaas@...gle.com>
Cc: Wei Huang <wei.huang2@....com>, <linux-pci@...r.kernel.org>,
 <linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>,
 <helgaas@...nel.org>, <davem@...emloft.net>, <edumazet@...gle.com>,
 <pabeni@...hat.com>, <asml.silence@...il.com>, <almasrymina@...gle.com>,
 <gospo@...adcom.com>, <michael.chan@...adcom.com>,
 <ajit.khaparde@...adcom.com>, <somnath.kotur@...adcom.com>,
 <andrew.gospodarek@...adcom.com>, <manoj.panicker2@....com>,
 <Eric.VanTassell@....com>
Subject: Re: [PATCH V1 1/2] bnxt_en: Add TPH support in BNXT driver

On Fri, 15 Nov 2024 14:04:11 -0600 Wei Huang wrote:
> +static void bnxt_irq_affinity_release(struct kref __always_unused *ref)

unused? you're using it now

> +{
> +	struct irq_affinity_notify *notify =
> +		(struct irq_affinity_notify *)
> +		container_of(ref, struct irq_affinity_notify, kref);

this is ugly, and cast is unnecessary.

> +	struct bnxt_irq *irq;
> +
> +	irq = container_of(notify, struct bnxt_irq, affinity_notify);

since you init irq out of line you can as well init notify here

> +	if (pcie_tph_set_st_entry(irq->bp->pdev, irq->msix_nr, 0)) {

You checked this function can sleep, right? Because rtnl_lock()
will sleep.


Bjorn, do you have a strong preference to have a user of the TPH code
merged as part of 6.13?  We're very close to the merge window, I'm not
sure build bots etc. will have enough time to hammer this code.
My weak preference would be to punt these driver changes to 6.14
avoid all the conflicts and risks (unless Linus gives us another week.)
-- 
pw-bot: nap