netdev - Re: [net-next PATCH v5 3/4] net: dsa: Add Airoha AN8855 5-Port Gigabit DSA Switch driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20241115145918.5ed4d5ec@kernel.org>
Date: Fri, 15 Nov 2024 14:59:18 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Christian Marangi <ansuelsmth@...il.com>
Cc: Andrew Lunn <andrew@...n.ch>, Florian Fainelli <f.fainelli@...il.com>,
 Vladimir Oltean <olteanv@...il.com>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Paolo Abeni
 <pabeni@...hat.com>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
 <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Heiner Kallweit
 <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>, Matthias
 Brugger <matthias.bgg@...il.com>, AngeloGioacchino Del Regno
 <angelogioacchino.delregno@...labora.com>,
 linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
 netdev@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, upstream@...oha.com
Subject: Re: [net-next PATCH v5 3/4] net: dsa: Add Airoha AN8855 5-Port
 Gigabit DSA Switch driver

On Fri, 15 Nov 2024 22:59:18 +0100 Christian Marangi wrote:
> On Thu, Nov 14, 2024 at 07:22:02PM -0800, Jakub Kicinski wrote:
> > On Tue, 12 Nov 2024 21:47:26 +0100 Christian Marangi wrote:  
> > > +	MIB_DESC(1, 0x00, "TxDrop"),
> > > +	MIB_DESC(1, 0x04, "TxCrcErr"),  
> > 
> > What is a CRC Tx error :o 
> > Just out of curiosity, not saying its worng.
> >  
> 
> From Documentation, FCS error frame due to TX FIFO underrun.

Interesting

> > > +	MIB_DESC(1, 0x08, "TxUnicast"),
> > > +	MIB_DESC(1, 0x0c, "TxMulticast"),
> > > +	MIB_DESC(1, 0x10, "TxBroadcast"),
> > > +	MIB_DESC(1, 0x14, "TxCollision"),  
> > 
> > Why can't these be rtnl stats, please keep in mind that we ask that
> > people don't duplicate in ethtool -S what can be exposed via standard
> > stats
> >   
> 
> Ok I will search for this but it does sounds like something new and not
> used by other DSA driver, any hint on where to look for examples?

It's relatively recent but I think the ops are plumbed thru to DSA.
Take a look at all the *_stats members of struct dsa_switch_ops, most
of them take a fixed format struct to fill in and the struct has some
extra kdoc on which field is what.