netdev - Re: [PATCH] rust: simplify Result<()> uses

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZzpAGXVfBkJ23gCD@shell.armlinux.org.uk>
Date: Sun, 17 Nov 2024 19:12:25 +0000
From: "Russell King (Oracle)" <linux@...linux.org.uk>
To: manas18244@...td.ac.in, Andrew Lunn <andrew@...n.ch>
Cc: FUJITA Tomonori <fujita.tomonori@...il.com>,
	Trevor Gross <tmgross@...ch.edu>,
	Heiner Kallweit <hkallweit1@...il.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Andreas Hindborg <a.hindborg@...nel.org>,
	Boqun Feng <boqun.feng@...il.com>, Miguel Ojeda <ojeda@...nel.org>,
	Alex Gaynor <alex.gaynor@...il.com>, Gary Guo <gary@...yguo.net>,
	Björn Roy Baron <bjorn3_gh@...tonmail.com>,
	Benno Lossin <benno.lossin@...ton.me>,
	Alice Ryhl <aliceryhl@...gle.com>,
	Shuah Khan <skhan@...uxfoundation.org>,
	Anup Sharma <anupnewsmail@...il.com>, netdev@...r.kernel.org,
	rust-for-linux@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-block@...r.kernel.org
Subject: Re: [PATCH] rust: simplify Result<()> uses

Let's try that again... with Manas' address pasted in _before_ Andrew's
"A" !

On Sun, Nov 17, 2024 at 06:56:31PM +0000, Russell King (Oracle) wrote:
> On Sun, Nov 17, 2024 at 07:25:48PM +0100, Andrew Lunn wrote:
> > On Sun, Nov 17, 2024 at 08:41:47PM +0530, Manas via B4 Relay wrote:
> > > From: Manas <manas18244@...td.ac.in>
> > > 
> > > This patch replaces `Result<()>` with `Result`.
> > > 
> > > Suggested-by: Miguel Ojeda <ojeda@...nel.org>
> > > Link: https://github.com/Rust-for-Linux/linux/issues/1128
> > > Signed-off-by: Manas <manas18244@...td.ac.in>
> > > ---
> > >  drivers/net/phy/qt2025.rs        | 2 +-
> > >  rust/kernel/block/mq/gen_disk.rs | 2 +-
> > >  rust/kernel/uaccess.rs           | 2 +-
> > >  rust/macros/lib.rs               | 6 +++---
> > 
> > Please split these patches up per subsystem, and submit them
> > individually to the appropriate subsystems.
> 
> In addition, it would be good if the commit stated the rationale for
> the change, rather than what the change is (which we can see from the
> patch itself.)
> 
> -- 
> RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
> FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 80Mbps down 10Mbps up. Decent connectivity at last!