netdev - RE: [Intel-wired-lan] [PATCH iwl-net 02/10] virtchnl: add PTP virtchnl definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <PH7PR11MB58855E8700EB1C1A64CA83EF8E272@PH7PR11MB5885.namprd11.prod.outlook.com>
Date: Mon, 18 Nov 2024 12:57:04 +0000
From: "Olech, Milena" <milena.olech@...el.com>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>,
	"intel-wired-lan@...ts.osuosl.org" <intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, "Kitszel, Przemyslaw"
	<przemyslaw.kitszel@...el.com>, "Lobakin, Aleksander"
	<aleksander.lobakin@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-net 02/10] virtchnl: add PTP
 virtchnl definitions

On 11/14/2024 6:29 PM, Willem de Bruijn wrote:

> Milena Olech wrote:
> > PTP capabilities are negotiated using virtchnl commands. There are two
> > available modes of the PTP support: direct and mailbox. When the direct
> > access to PTP resources is negotiated, virtchnl messages returns a set
> > of registers that allow read/write directly. When the mailbox access to
> > PTP resources is negotiated, virtchnl messages are used to access
> > PTP clock and to read the timestamp values.
> >
> > Virtchnl API covers both modes and exposes a set of PTP capabilities.
> >
> > Using virtchnl API, the driver recognizes also HW abilities - maximum
> > adjustment of the clock and the basic increment value.
> >
> > Additionally, API allows to configure the secondary mailbox, dedicated
> > exclusively for PTP purposes.
> >
> > Reviewed-by: Alexander Lobakin <aleksander.lobakin@...el.com>
> > Signed-off-by: Milena Olech <milena.olech@...el.com>
>
> minor issue, with that addressed
>
> Reviewed-by: Willem de Bruijn <willemb@...gle.com>
>
>
> > +/**
> > + * struct virtchnl2_ptp_set_dev_clk_time: Associated with message
> > + *					  VIRTCHNL2_OP_PTP_SET_DEV_CLK_TIME.
> > + * @dev_time_ns: Device time value expressed in nanoseconds to set
> > + *
> > + * PF/VF sends this message to set the time of the main timer.
> > + */
> > +struct virtchnl2_ptp_set_dev_clk_time {
> > +	__le64 dev_time_ns;
> > +};
> > +VIRTCHNL2_CHECK_STRUCT_LEN(8, virtchnl2_ptp_set_dev_clk_time);
> > +
> > +/**
> > + * struct virtchnl2_ptp_set_dev_clk_time: Associated with message
> > + *					  VIRTCHNL2_OP_PTP_ADJ_DEV_CLK_FINE.
>
> minor: virtchnl2_ptp_adj_dev_clk_fine

Correct, I'll fix it in v2

>
> > + * @incval: Source timer increment value per clock cycle
> > + *
> > + * PF/VF sends this message to adjust the frequency of the main timer by the
> > + * indicated scaled ppm.
> > + */
> > +struct virtchnl2_ptp_adj_dev_clk_fine {
> > +	__le64 incval;
> > +};
> > +VIRTCHNL2_CHECK_STRUCT_LEN(8, virtchnl2_ptp_adj_dev_clk_fine);
>

Thanks,
Milena