netdev - Re: [PATCH] rocker: fix link status detection in rocker_carrier

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZzxaNFWQlamJJjFS@nanopsycho.orion>
Date: Tue, 19 Nov 2024 10:28:20 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Ido Schimmel <idosch@...sch.org>, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S . Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	netdev@...r.kernel.org
Subject: Re: [PATCH] rocker: fix link status detection in
 rocker_carrier_init()

Tue, Nov 19, 2024 at 03:42:01AM CET, kuba@...nel.org wrote:
>On Thu, 14 Nov 2024 18:19:46 +0300 Dmitry Antipov wrote:
>> Since '1 << rocker_port->pport' may be undefined for port >= 32,
>> cast the left operand to 'unsigned long long' like it's done in
>> 'rocker_port_set_enable()' above. Compile tested only.
>
>Jiri, random thought - any sense if anyone still uses rocker?
>IIUC the goal was similar to netdevsim - SW testing / modeling
>but we don't really have any upstream tests against it..

Afaik some people are still using it for testing. I got couple emails in
the past. Not sure now. The thing is, rocker has real datapath,
comparing to netdevsim.

>
>Unrelated to the patch, so dropping the author from CC.