netdev - Re: [PATCH net-next V3 3/8] devlink: Extend devlink rate API with traffic classes bandwidth management

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zzxa13xPBZGxRC01@nanopsycho.orion>
Date: Tue, 19 Nov 2024 10:31:03 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Carolina Jubran <cjubran@...dia.com>
Cc: Tariq Toukan <tariqt@...dia.com>,
	"David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	Eric Dumazet <edumazet@...gle.com>,
	Andrew Lunn <andrew+netdev@...n.ch>, netdev@...r.kernel.org,
	Saeed Mahameed <saeedm@...dia.com>, Gal Pressman <gal@...dia.com>,
	Leon Romanovsky <leonro@...dia.com>,
	Cosmin Ratiu <cratiu@...dia.com>, donald.hunter@...il.com
Subject: Re: [PATCH net-next V3 3/8] devlink: Extend devlink rate API with
 traffic classes bandwidth management

Mon, Nov 18, 2024 at 08:36:38PM CET, cjubran@...dia.com wrote:
>
>
>On 18/11/2024 10:37, Jiri Pirko wrote:
>> Sun, Nov 17, 2024 at 09:50:40PM CET, tariqt@...dia.com wrote:
>> > From: Carolina Jubran <cjubran@...dia.com>

[...]

>> > diff --git a/Documentation/netlink/specs/devlink.yaml b/Documentation/netlink/specs/devlink.yaml
>> > index 09fbb4c03fc8..fece78ed60fe 100644
>> > --- a/Documentation/netlink/specs/devlink.yaml
>> > +++ b/Documentation/netlink/specs/devlink.yaml
>> > @@ -820,6 +820,19 @@ attribute-sets:
>> >        -
>> >          name: region-direct
>> >          type: flag
>> > +      -
>> > +        name: rate-tc-bw
>> > +        type: u32
>> > +        doc: |
>> > +             Specifies the bandwidth allocation for the Traffic Class as a
>> > +             percentage.
>> > +        checks:
>> > +          min: 0
>> > +          max: 100
>> > +      -
>> > +        name: rate-tc-bw-values
>> > +        type: nest
>> > +        nested-attributes: dl-rate-tc-bw-values
>> 
>> Hmm, it's not a simple nest. It's an array. You probably need something
>> like type: indexed-array here. Please make sure you make this working
>> with ynl. Could you also please add examples of get and set commands
>> using ynl to the patch description?
>> 
>> 
>
>It seems that type: indexed-array with sub-type: u32 would be the correct
>approach. However, I noticed that this support appears to be missing in the
>ynl-gen-c.py script in this series:
>https://lore.kernel.org/all/20240404063114.1221532-3-liuhangbin@gmail.com/.
>If this is indeed the case, how should I specify the min and max values for
>the u32 entries in the indexed-array?

Not sure. Perhaps Jakub/Donald would know. Ccing.